Skip to content

Split PR for MAISI augmentation #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Conversation

Can-Zhao
Copy link
Contributor

@Can-Zhao Can-Zhao commented Jul 2, 2024

Fixes # .

Description

Add MAISI augmentation funcs.
Refactor code: support cpu and gpu, unify the variable names, logic flow, and format of the five functions

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

root and others added 2 commits July 2, 2024 20:09
@Can-Zhao Can-Zhao marked this pull request as ready for review July 2, 2024 22:14
@Can-Zhao Can-Zhao requested review from guopengf and KumoLiu July 2, 2024 22:14
@Can-Zhao
Copy link
Contributor Author

Can-Zhao commented Jul 2, 2024

@KumoLiu Hi Yun, I created two small funcs to reuse some code. And tried my best to support cpu and gpu, unify the variable names, logic flow, and format of the five functions. I know there is more space to improve. But we do have to move on. Due is ahead.

Copy link
Contributor

@guopengf guopengf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. I also run local tests for augmentation of 5 tumor types. Augmentation results are expected except the pancreatic tumor.

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, overall looks good to me.
One one minor comments inline.

@guopengf guopengf mentioned this pull request Jul 3, 2024
5 tasks
@Can-Zhao
Copy link
Contributor Author

Can-Zhao commented Jul 3, 2024

Overall, LGTM. I also run local tests for augmentation of 5 tumor types. Augmentation results are expected except the pancreatic tumor.

Thank you testing it!!

Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall we merge it @KumoLiu ?

@KumoLiu KumoLiu merged commit cb1c1f3 into Project-MONAI:main Jul 4, 2024
6 checks passed
@Can-Zhao Can-Zhao deleted the maisi_aug branch July 4, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants