-
Notifications
You must be signed in to change notification settings - Fork 739
Split PR for MAISI augmentation #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: root <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
@KumoLiu Hi Yun, I created two small funcs to reuse some code. And tried my best to support cpu and gpu, unify the variable names, logic flow, and format of the five functions. I know there is more space to improve. But we do have to move on. Due is ahead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM. I also run local tests for augmentation of 5 tumor types. Augmentation results are expected except the pancreatic tumor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, overall looks good to me.
One one minor comments inline.
Signed-off-by: Can-Zhao <[email protected]>
Thank you testing it!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Shall we merge it @KumoLiu ?
Fixes # .
Description
Add MAISI augmentation funcs.
Refactor code: support cpu and gpu, unify the variable names, logic flow, and format of the five functions
Checks
./figure
folder./runner.sh -t <path to .ipynb file>