-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Integrate Maybe and Single into Observable. *** DO NOT MERGE #4481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Don't delete the old ops because we can macro fuse them back in such cases: |
I'll post a PR that incorporates some helper types and demoes what I mean by macro-fusion for these Flowable->X and Observable->X conversions. |
@abersnaze Your commit somehow has me as it's author. |
@Mauin yeah it's odd @abersnaze Also it would be great if you didn't mix plain addition to |
Yes, that would be great. |
Let me take out the Maybe additions into a separate PR. |
Reactor's Flowable.range(1, 10)
.flatMap(v -> .saveToDb(restCall(v)).ignoreElements().toFlowable())
.blockingLast(0) To avoid this burden, we have to provide |
…cases where is it returning a 1 or 0 values.
069726c
to
2cf2bab
Compare
Closing as out of date and will be redone in subsequent PRs. |
I've been working on the this for too long in the background and want to get this out for review even though many of the units tests don't pass yet. Its a bit rough at the moment but there was a couple of things that I wanted to talk about.