2.x: add new methods to Maybe, Observable and Single from 4481 #4488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -701,6 +701,34 @@ | |||
| // ------------------------------------------------------------------ | |||
|
|
|||
| /** | |||
| * Waits in a blocking fashion until the current Maybe signals a success value (which is returned) or | |||
| * defaultValue if completed or an exception (which is propagated). | |||
|
👍 |
Current coverage is 77.79% (diff: 8.16%)@@ 2.x #4488 diff @@
==========================================
Files 497 500 +3
Lines 33772 33909 +137
Methods 0 0
Messages 0 0
Branches 5303 5325 +22
==========================================
- Hits 26396 26378 -18
- Misses 5409 5554 +145
- Partials 1967 1977 +10
|
|
Updated with corrections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds just the new methods from #4481 to allow a much cleaner change of return types later on.