Skip to content

rust: require mutable references when initialising sync primitives. #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

wedsonaf
Copy link

This prevents initialising synchronisation primitives when there are
multiple references to them.

Based on #391.

Signed-off-by: Wedson Almeida Filho [email protected]

@ksquirrel

This comment has been minimized.

@ksquirrel

This comment has been minimized.

This prevents initialising synchronisation primitives when there are
multiple references to them.

Signed-off-by: Wedson Almeida Filho <[email protected]>
@ksquirrel
Copy link
Member

Review of 8168bc13e0e4:

  • ✔️ Commit 8168bc1: Looks fine!

@wedsonaf
Copy link
Author

Rebased now that #391 is merged.

Copy link
Member

@nbdd0121 nbdd0121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Quite unfortunate that we don't have pin projection so that a lot of unsafe is required.

@ojeda ojeda merged commit c76ea62 into Rust-for-Linux:rust Jun 27, 2021
@wedsonaf wedsonaf deleted the init-sync branch June 27, 2021 00:29
@TheSven73
Copy link
Collaborator

Quite unfortunate that we don't have pin projection so that a lot of unsafe is required.

Agreed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants