-
Notifications
You must be signed in to change notification settings - Fork 465
Add Samsung Exynos true random number generator driver #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rust
Are you sure you want to change the base?
Add Samsung Exynos true random number generator driver #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few random comments (pun not intended :)
Signed-off-by: Maciej Falkowski <[email protected]>
Signed-off-by: Maciej Falkowski <[email protected]>
243b240
to
066f805
Compare
Signed-off-by: Maciej Falkowski <[email protected]>
Signed-off-by: Maciej Falkowski <[email protected]>
Signed-off-by: Maciej Falkowski <[email protected]>
Signed-off-by: Maciej Falkowski <[email protected]>
Signed-off-by: Maciej Falkowski <[email protected]>
Signed-off-by: Maciej Falkowski <[email protected]>
066f805
to
667e142
Compare
@ojeda May I ask Miguel, the first patches of the patchset have been significantly improved, thus I think I could start submitting them one by one in separates pull requests. The last patches related to What would you prefer? |
Yeah, please feel free to split the PR into several. The smaller they are, the easier they are to take (as long as commits are consistent, i.e. that they do not break the build). |
Hello,
As a part of the introduction of our kernel team to the RustForLinux project,
I created a driver that is a port of Samsung Exynos true random number generator that now I would like to present.
This is mainly a request for an initial code review. There are some patches that are not yet prepared and require some design decisions. The power management of the driver is for now skipped as it was not needed to get the driver working.
The driver is tested on the ODROID-XU3 board (Exynos 5422).
ioremap_resource
andget_resource
methods #682try_memcpy_fromio
method forIoMem<T>
#681