Skip to content

Add Samsung Exynos true random number generator driver #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: rust
Choose a base branch
from

Conversation

m-falkowski1
Copy link

@m-falkowski1 m-falkowski1 commented Nov 15, 2021

Hello,

As a part of the introduction of our kernel team to the RustForLinux project,
I created a driver that is a port of Samsung Exynos true random number generator that now I would like to present.

This is mainly a request for an initial code review. There are some patches that are not yet prepared and require some design decisions. The power management of the driver is for now skipped as it was not needed to get the driver working.

The driver is tested on the ODROID-XU3 board (Exynos 5422).


@m-falkowski1 m-falkowski1 changed the title Add Samsung Exynos true random number generator Add Samsung Exynos true random number generator driver Nov 15, 2021
@m-falkowski1 m-falkowski1 marked this pull request as draft November 15, 2021 13:14
Copy link
Member

@ojeda ojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few random comments (pun not intended :)

Maciej Falkowski added 2 commits November 29, 2021 16:53
@m-falkowski1 m-falkowski1 force-pushed the add_exynos_rust_hwrng branch 2 times, most recently from 243b240 to 066f805 Compare November 29, 2021 16:18
@m-falkowski1
Copy link
Author

m-falkowski1 commented Nov 29, 2021

@ojeda May I ask Miguel, the first patches of the patchset have been significantly improved, thus I think I could start submitting them one by one in separates pull requests. The last patches related to io_mem and iopoll are still much in progress so maybe it would be better to await them?

What would you prefer?
Best regards

@ojeda
Copy link
Member

ojeda commented Nov 29, 2021

Yeah, please feel free to split the PR into several. The smaller they are, the easier they are to take (as long as commits are consistent, i.e. that they do not break the build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants