Skip to content

rust: iomem: add try_memcpy_fromio method for IoMem<T> #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

m-falkowski1
Copy link

@m-falkowski1 m-falkowski1 commented Feb 17, 2022

This patch adds only runtime-checked bindings version of
memcpy_fromio() function prefixed with try_ similarly
to read/write methods of IoMem<T> that is readx and try_readx.

This patch is a dependency of a Samsung Exynos trng driver provided initially in #554.

Changes v3 -> v4:

Changes v2 -> v3:

  • Error::EINVAL -> EINVAL,

Changes v1 -> v2:

Signed-off-by: Maciej Falkowski [email protected]

@m-falkowski1
Copy link
Author

v2 posted.

@m-falkowski1
Copy link
Author

Rebased.

@m-falkowski1
Copy link
Author

v3 rebased to the newest changes.

@m-falkowski1 m-falkowski1 requested a review from wedsonaf March 17, 2022 13:26
@m-falkowski1
Copy link
Author

May you please reopen the issue? I messed with github, sorry for the situation.

@wedsonaf
Copy link

May you please reopen the issue? I messed with github, sorry for the situation.

I'm getting a message saying that branch was "force-pushed or recreated".

Could you try to:

  1. Force push the branch back to b4bffd8
  2. Reopen the PR
  3. Force push to the latest version

I'm not sure if it will work, but worth a try.

@m-falkowski1 m-falkowski1 reopened this Mar 17, 2022
This patch adds only runtime-checked bindings version of
`memcpy_fromio()` function prefixed with `try_` similarly
to read/write methods of `IoMem<T>` that is `readx` and `try_readx`.

Signed-off-by: Maciej Falkowski <[email protected]>
@m-falkowski1
Copy link
Author

Thanks :) Worked perfectly

@ojeda
Copy link
Member

ojeda commented Mar 17, 2022

May you please reopen the issue? I messed with github, sorry for the situation.

A partial outage has just been resolved -- it may have been due to that. There was another one yesterday too, Actions did not work well for me.

@wedsonaf wedsonaf merged commit c1ff23e into Rust-for-Linux:rust Mar 17, 2022
@m-falkowski1 m-falkowski1 deleted the add_memcpy_fromio branch March 17, 2022 16:37
@m-falkowski1
Copy link
Author

May you please reopen the issue? I messed with github, sorry for the situation.

A partial outage has just been resolved -- it may have been due to that. There was another one yesterday too, Actions did not work well for me.

Seems so, before pushing the branch I had major problems with Github. After the push, the branch did not sync.

@wedsonaf
Copy link

May you please reopen the issue? I messed with github, sorry for the situation.

A partial outage has just been resolved -- it may have been due to that. There was another one yesterday too, Actions did not work well for me.

Seems so, before pushing the branch I had major problems with Github. After the push, the branch did not sync.

I was having a hard time posting my second comment. I would push the button and nothing would happen. An outage explains that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants