Enhance tests for FetchNode with mocking #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the test suite for the FetchNode class by introducing mocking for the execute method using the unittest.mock module. Changes: - Imported the patch and MagicMock classes from unittest.mock. - Decorated each test function with @patch('scrapegraphai.nodes.FetchNode.execute') to mock the execute method. - Set the return_value of the mocked execute method to a MagicMock instance. - Added assertions to check if the mocked execute method was called with the expected state dictionary. - Updated the test functions to use the mocked execute method instead of the actual implementation. Benefits: - Improved test reliability by isolating the FetchNode class from external dependencies. - Faster test execution since external resources (e.g., URLs, files) are not required. - Better test coverage by testing the execute method's behavior with various input states. - Increased maintainability by decoupling tests from the implementation details of the execute method. The functionality of the FetchNode class remains unchanged, but the tests now use mocking to ensure the correct behavior of the execute method without relying on external resources or dependencies.
|
hi, we would be glad if you can update also the other nodes test, thank you! |
|
Thank you for merging the pull request and for the feedback! I will be glad to update the tests for the other nodes as well. |
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.6.0-beta.11 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the test suite for the FetchNode class by introducing mocking for the execute method using the unittest.mock module.
Changes:
Benefits:
The functionality of the FetchNode class remains unchanged, but the tests now use mocking to ensure the correct behavior of the execute method without relying on external resources or dependencies.