Skip to content

WIP: add ability to install specific chrome version. fixes #266 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2016

Conversation

ddavison
Copy link
Member

@ddavison ddavison commented Sep 8, 2016

hold off merging until I test this thoroughly. I will merge it in once i'm done.

@davehunt
Copy link
Contributor

davehunt commented Sep 8, 2016

@ddavison if your comfortable doing merges on this repo, then would you mind taking a look at #251 which does something similar for the Selenium server component and Firefox?

@ddavison
Copy link
Member Author

ddavison commented Sep 8, 2016

sure thing, @davehunt

@ddavison ddavison merged commit 19f1935 into master Sep 9, 2016
@ddavison ddavison deleted the specific-chrome-version branch September 9, 2016 21:29
@finspin
Copy link

finspin commented Mar 8, 2017

Is this waiting for tests? We would need this feature because we need to use some older versions of Chrome.

@elgalu
Copy link
Member

elgalu commented Mar 9, 2017

I don't how this can work for installing old versions of chrome, right now we are on Chrome 56 (stable) and if I try to install Chrome 53 the package is not listed anymore:

E: Version '53.0.2785.101-1' for 'google-chrome-stable' was not found

What am I missing?

@ddavison
Copy link
Member Author

@elgalu:

BUILD_ARGS="--build-arg CHROME_DRIVER_VERSION=2.23 --build-arg CHROME_VERSION=google-chrome-beta=53.0.2785.92-1" make chrome chrome_debug standalone_chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants