Add support for Selenium 2.53.1 and Firefox 47.0.1 #251
Conversation
|
@kayabendroth would you mind taking a look at this? I'd like to follow it up with introduction of Selenium 3.0b with GeckoDriver and Marionette support for Firefox 48. I could merge myself, but I'm unfamiliar with the release process. |
Make Firefox 47.0.1 the default version
|
Perhaps @RubyTester could help review/merge/release? |
| @@ -27,7 +27,9 @@ RUN apt-get update -qqy \ | |||
| # Selenium | |||
| #========== | |||
| RUN mkdir -p /opt/selenium \ | |||
| && wget --no-verbose https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar -O /opt/selenium/selenium-server-standalone.jar | |||
| && wget --no-verbose https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar -O /opt/selenium/selenium-server-standalone-2.53.0.jar \ | |||
There was a problem hiding this comment.
This line has to go away. You download two versions of Selenium.
There was a problem hiding this comment.
This is intentional - to allow the user to control which version is used. We wouldn't want to download many versions, but it would allow us for example to include beta versions.
|
@kayabendroth would you mind taking another look - I've switch to a for-loop when downloading the Firefox versions now. |
| if [ ! -z "$FIREFOX_VERSION" ]; then | ||
| sudo ln -fs /opt/firefox/${FIREFOX_VERSION}/firefox /usr/bin/firefox | ||
| fi | ||
|
|
There was a problem hiding this comment.
so no matter what time of node you are using, firefox will be in /usr/bin/firefox? say i'm using NodeChrome, /usr/bin/firefox will exist?
There was a problem hiding this comment.
i'm aware that it's a no-op if you, of course, do not specify FIREFOX_VERSION, but still interested to hear your reasoning :)
There was a problem hiding this comment.
Like you point out it will only be created if FIREFOX_VERSION is specified. I'm happy to take another approach if you have an idea?
There was a problem hiding this comment.
would it make more sense to just put this piece in NodeFirefox and NodeFirefoxDebug, StandaloneFirefox and StandaloneFirefoxDebug?
There was a problem hiding this comment.
This entry point isn't overridden in some of those, so I think I'd rather keep this here than complicate this further. I'll be opening a new pull request after rebasing from the recent changes shortly.
|
This has been superseded by #271 |
This adds support for Selenium 2.53.1 and Firefox 47.0.1 in addition to making them the default versions, however I have also introduced an environment variable for each to allow users to opt for previous versions. This will allow us to introduce beta versions that will not be the defaults, and will also offer the ability to workaround compatibility issues between the various dependencies.
This essentially makes #226 and #250 obsolete (except for the ChromeDriver update, but that was also taken care of in #234).