Add support for Selenium 3.0.0-beta4 and Firefox 48 & 49 #271
Conversation
|
Hi @davehunt , When can we expect this pull request to be merged and available for public to use? |
|
I'm not sure @dgangwar - I think @kayabendroth has been busy with other projects recently. Hopefully they'll have some time to return to this project. Otherwise, perhaps someone else such as @ddavison could help to get this merged and released? I would do it, but I don't have time to commit to this project beyond the occasional patch. |
|
Good job !! |
|
ping @ddavison and @kayabendroth |
|
Need this - firefox node does not work in docker had to build this image from scratch. |
| && ln -fs /opt/firefox-$FIREFOX_VERSION/firefox /usr/bin/firefox | ||
| && apt-get -y purge firefox | ||
| ENV FIREFOX_VERSION 47.0.1 | ||
| RUN for VERSION in 48.0.2 47.0.1 46.0.1 45.0.2; do \ |
There was a problem hiding this comment.
not sure if it is good, as it would have make the image larger, but it did include more versions in one env to make it easy to test
There was a problem hiding this comment.
The image size will be limited to the versions of Firefox supported. That said, my list here is not correct, as Selenium supports "the latest release, the previous release, the latest ESR release and the previous ESR release." I will therefore update this to be: 49.0.1, 48.0.2, 45.4.0esr, 38.8.0esr.
There was a problem hiding this comment.
I think it makes sense to keep 47.0.1 for now, as it's the latest version supported without GeckoDriver and is the current default version, and I'd like to allow a release of a new docker image without forcing GeckoDriver before Selenium 3 is out of beta.
| && mv /opt/geckodriver /opt/geckodriver-$GECKODRIVER_VERSION \ | ||
| && chmod 755 /opt/geckodriver-$GECKODRIVER_VERSION \ | ||
| && ln -fs /opt/geckodriver-$GECKODRIVER_VERSION /usr/bin/geckodriver \ | ||
| && ln -fs /opt/geckodriver-$GECKODRIVER_VERSION /usr/bin/wires |
There was a problem hiding this comment.
for wires rename, do we know which firefox version need that ?
There was a problem hiding this comment.
This is not a requirement of Firefox, but of the Selenium: 2.53.x expects wires but 3.x expects geckodriver.
| these using the following environment variables: | ||
|
|
||
| - `SELENIUM_VERSION` - version of the Selenium server | ||
| - `FIREFOX_VERSION` - version of Firefox (only applies to Firefox images) |
There was a problem hiding this comment.
I think it is better to list the version we supported here, since image users not know which versions is included in that image
There was a problem hiding this comment.
Good idea, I'll update this too.
davehunt
changed the title
|
@HackToday @ddavison @kayabendroth ready for review again |
| Note that as the latest releases of Firefox work best with Selenium 3.0, which | ||
| is currently in beta, the latest release supported by 2.53.x is `47.0.1` and is | ||
| also available (and the default). | ||
|
|
There was a problem hiding this comment.
If I remember my test before, the 2.53.x can work with Firefox 47.0.1 if not use caps["marionette"] = True.
if you use caps["marionette"] = True to run selenium test. it would fail.
This is my only concern here for various versions matrix.
Other code LGTM.
There was a problem hiding this comment.
2.53.x should work against Firefox 47.0.1 with marionette=True. It's the first version of Firefox that was officially supported by GeckoDriver, so there certainly were more bugs in that version than there are in later releases.
davehunt
changed the title
|
Updated to beta4. |
|
closed with mutual respect. 😉 |
|
not necessary just that commit @HackToday . I've pushed up a 3.0.0-beta4 and 3.0.0-beta3 tag. both beta versions have firefox 49.0.1 |
@kayabendroth @ddavison r?