Remove Gemfile.lock for Ruby head #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Jan 10, 2024
st0012
approved these changes
Jan 10, 2024
andyw8
force-pushed
the
andyw8/rm-gemfile-lock-for-head
branch
5 times, most recently
from
11a0728 to
cdbd144
Compare
andyw8
force-pushed
the
andyw8/rm-gemfile-lock-for-head
branch
from
cdbd144 to
7a31bdd
Compare
andyw8
commented
Jan 10, 2024
| @@ -28,8 +28,8 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
|
|
|||
| - name: Remove Gemfile.lock | |||
| if: matrix.os == 'windows-latest' && matrix.ruby == '3.1' | |||
| run: rm Gemfile.lock | |||
There was a problem hiding this comment.
This was invalid previously because it was removing the wrong lockfile in cases where the gemfile was Gemfile-rails-main. It seems the gemspec entry in the Gemfile wasn't playing well with a Gemfile contained in a subdirectory, so I moved it up to the root.
|
Ah, I should have used the |
Merged
andyw8
added a commit
that referenced
this pull request
Jan 12, 2024
Remove Gemfile.lock for Ruby head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent failures such as: