Set process group ID in server to terminate after parent #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/set_process_group_id_in_server
branch
from
5ab230f to
0afc8bb
Compare
|
Actually, this doesn't work properly. We sometimes get an operation not permitted error. We'll need to think about alternatives. |
andyw8
force-pushed
the
vs/set_process_group_id_in_server
branch
from
0afc8bb to
c53dd0e
Compare
andyw8
force-pushed
the
vs/set_process_group_id_in_server
branch
from
c53dd0e to
12b2674
Compare
andyw8
approved these changes
Feb 29, 2024
|
Thank you @vinistock! 🙇 |
|
@tisba my pleasure! Is the problem fixed on your end? |
|
I haven't seen it since I updated right away when I saw this PR merged and v0.3.2 released. But as I wrote in #274 I'm not sure how to reproduce the issue reliably. Will certainly report back if the issue reappears. |
|
Sounds good. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #274
I think there are two issues with the way we shutdown the server. We can't have the infinite loop checking if the thread is alive, because something might go wrong with the server and then we'll never kill the child process. I removed that loop and switched to a single sleep to give some time for the server to shutdown.
Also, I started setting the process group ID in the server process. This is a similar trick used in spring, which makes it so that if the parent process is terminated, then so will the server.
I believe these two should help with the orphaned process issues we've been seeing.