Add definitions for Rails callbacks #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan-soni
force-pushed
the
as/definition-dsl-argument-methods
branch
from
24cd909 to
fa58345
Compare
|
|
|
I guess this is limited currently since it can't jump to definitions in another class (e.g. a common |
vinistock
reviewed
Mar 21, 2024
andyw8
reviewed
Mar 21, 2024
| module RubyLsp | ||
| module Rails | ||
| module Support | ||
| module Callbacks |
There was a problem hiding this comment.
Maybe CallbacksList to emphasize there's no behaviour in here?
andyw8
reviewed
Mar 21, 2024
andyw8
reviewed
Mar 21, 2024
aryan-soni
force-pushed
the
as/definition-dsl-argument-methods
branch
2 times, most recently
from
f672239 to
1a37bfe
Compare
andyw8
reviewed
Mar 21, 2024
aryan-soni
force-pushed
the
as/definition-dsl-argument-methods
branch
from
1a37bfe to
ec42db4
Compare
|
Let's add definition to this list. |
andyw8
approved these changes
Mar 21, 2024
…ming for callback module
aryan-soni
force-pushed
the
as/definition-dsl-argument-methods
branch
from
ec42db4 to
41114a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements definitions for callbacks in Rails, building on the approach leveraged for definitions inside
ruby-lsp.This PR also abstracts away the collection of Rails callbacks that we keep, since both the document symbol and definition features now rely on it. Moreover, generally, this PR introduces the definitions feature to the add-on, as it was not present previously.