Skip to content

Remove Sorbet from server.rb #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 16, 2024

For if we decide to go with this option (see discussion in issue).

Closes #336

@andyw8 andyw8 added the chore Chore task label Apr 16, 2024
@andyw8 andyw8 requested a review from a team as a code owner April 16, 2024 18:48
@andyw8 andyw8 requested review from st0012 and vinistock April 16, 2024 18:48
@andyw8 andyw8 force-pushed the andyw8/remove-sorbet-from-server-rb branch 2 times, most recently from 40988ab to c948cd4 Compare April 16, 2024 18:53
@st0012
Copy link
Member

st0012 commented Apr 16, 2024

Oh sorry I thought the decision has already been made.

@andyw8
Copy link
Contributor Author

andyw8 commented Apr 16, 2024

I'll set back to draft until we verify the other way is valid.

@andyw8 andyw8 marked this pull request as draft April 16, 2024 21:05
@andyw8 andyw8 force-pushed the andyw8/remove-sorbet-from-server-rb branch from c948cd4 to 3c2ed94 Compare May 1, 2024 15:16
@andyw8 andyw8 marked this pull request as ready for review May 1, 2024 15:16
@andyw8
Copy link
Contributor Author

andyw8 commented May 1, 2024

(@vinistock has ok'd this)

@andyw8 andyw8 enabled auto-merge (squash) May 1, 2024 15:18
@andyw8 andyw8 disabled auto-merge May 1, 2024 15:29
@andyw8 andyw8 force-pushed the andyw8/remove-sorbet-from-server-rb branch from b2d4dc2 to 3f5fcbe Compare May 1, 2024 15:37
@andyw8 andyw8 merged commit cb8857a into main May 1, 2024
@andyw8 andyw8 deleted the andyw8/remove-sorbet-from-server-rb branch May 1, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure for sorbet-runtime on new Rails app
2 participants