WIP: Ensure sorbet-runtime available for runner #340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/ensure-sorbet-runtime-available-for-runner
branch
from
601db3e to
6ab6835
Compare
|
@vinistock this a little tricky to test because if I edit ".ruby-lsp/Gemfile" it will be overwritten when the LSP restarts... I seem to remember there was some workaround for that? |
vinistock
reviewed
Apr 16, 2024
|
|
||
| # TODO: fix signature | ||
| stdin, stdout, stderr, wait_thread = T.unsafe(Open3).popen3( | ||
| env, |
There was a problem hiding this comment.
I wonder if we can't simply pass ENV here and have it inherit the entire environment.
That would also make it easier to test, you could just add a bogus ENV value and verify that popen3 gets invoked with it.
|
We went with #339 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix for #336. Still to test.