Re-order CI steps #362
Merged
Re-order CI steps #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
May 2, 2024
| @@ -52,8 +52,5 @@ jobs: | |||
| - name: Lint Ruby files | |||
| run: bin/rubocop | |||
|
|
|||
| - name: Lint Ruby files | |||
vinistock
requested changes
May 2, 2024
There was a problem hiding this comment.
Let's remove the duplication, but I disagree with the ordering change. We should always run the fastest checks first.
Maybe we can instead do what we did in the Ruby LSP and move linting, type checking and docs to a separate job that doesn't run on every Ruby version?
andyw8
force-pushed
the
andyw8/re-order-ci-steps
branch
from
437527a to
be9b79c
Compare
|
Split into two jobs (ignore the Windows failures, see #365) Once this is merged we probably need to add |
vinistock
approved these changes
May 2, 2024
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are the most likely thing to fail, so let's run those first, so we get earlier feedback.