Return type accuracy and usage improvements #7891
Open
+353
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
bug
APickledWalrus
added
the
enhancement
APickledWalrus
added
the
needs testing
APickledWalrus
requested review from
UnderscoreTud and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
APickledWalrus
changed the title
APickledWalrus
commented
May 23, 2025
This was referenced May 23, 2025
sovdeeth
approved these changes
May 28, 2025
sovdeeth
approved these changes
Jun 2, 2025
Merged
1 task
erenkarakal
approved these changes
Jun 12, 2025
skriptlang-automation
bot
added
the
feature-ready
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Release
skriptlang-automation
bot
removed
the
needs reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some Expressions/Classes are not taking full advantage of the multiple return types system. Others have return types that are incorrectly setup. Ensuring detailed return types is also important for features like local variable type hints.
Solution
I aim to integrate usage of
Expression#possibleReturnTypesandExpression#canReturnwhere possible. I've also cleaned up some classes that were in need of it (to improve their return type logic).A major change that I made is
Expression#canReturnwill always return true if one of the possible return types is Object. This appears to work without issue, but further testing is needed.ExprTernary and ExprDefaultValue have been rewritten and their generics removed. I do not believe these are necessary anymore. The generic ConvertedExpression implementation is capable of ensuring type safety.
Testing Completed
There is existing coverage of most of the modified syntax. I have added tests for ExprTernary and ExprDefaultValue since they were rewritten and previously did not have any tests.
Supporting Information
n/a
Completes: Fixes #5060
Related: none