EffChange Cleanup #7915
Merged
EffChange Cleanup #7915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
enhancement
APickledWalrus
requested review from
UnderscoreTud and
TheMug06
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
Co-authored-by: SirSmurfy2 <[email protected]>
TheMug06
approved these changes
Jun 6, 2025
skriptlang-automation
bot
added
the
feature-ready
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Release
skriptlang-automation
bot
removed
the
needs reviews
Burbulinis
approved these changes
Jun 10, 2025
skriptlang-automation
bot
added
the
completed
skriptlang-automation
bot
removed
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EffChange is outdated: filled with oddly structured code, duplicated behavior, and confusing variable names. It is hard to understand what is going on in the class and follow the behavior.
Solution
I have cleaned up and rewritten the class. I've expanded variable names, added documentation, optimized behavior, and improved error messages.
Testing Completed
No additional tests were added. EffChange is widely used across the tests, and they continue to pass. I am not sure if it is worth adding an EffChange test (it would depend on other syntaxes change implementations).
Supporting Information
Sort of depends on #7891 (I've copied the
Expression#canReturnchanges)Completes: none
Related: none