Created equivalent_resistance under Electronics #6782
Conversation
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
electronics/resistor_equivalence.py
Outdated
| ValueError: Resistor at index 2 has a negative or zero value! | ||
| """ | ||
|
|
||
| firstSum = 0.00 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: firstSum
removed an unnecessary space Co-authored-by: Caeden <[email protected]>
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
electronics/resistor_equivalence.py
Outdated
| ValueError: Resistor at index 2 has a negative or zero value! | ||
| """ | ||
|
|
||
| firstSum = 0.00 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: firstSum
|
@Gmuslow please incorporate the naming convention suggested by the bot and update your code. |
fixed the snake_case requirement
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
electronics/resistor_equivalence.py
Outdated
| ValueError: Resistor at index 2 has a negative or zero value! | ||
| """ | ||
|
|
||
| first_Sum = 0.00 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: first_Sum
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
electronics/resistor_equivalence.py
Outdated
| ValueError: Resistor at index 2 has a negative or zero value! | ||
| """ | ||
|
|
||
| first_Sum = 0.00 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: first_Sum
finalize the naming convention errors (hopefully)
algorithms-keeper
bot
removed
the
awaiting reviews
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
awaiting reviews
Describe your change:
Hi all,
I added the equivalent_resistance package to the electronics folder!
This is my first time contributing to open source so please let me know if you have any suggestions!
Checklist:
Fixes: #{$ISSUE_NO}.