Create calculate_resistence_in_series.py #7834
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
cclauss
added
the
ON HOLD: Final hours of Hacktoberfest
CaedenPH
reviewed
Oct 29, 2022
Comment on lines
+11
to
+14
| total = 0 | ||
| for val in resistors_in_series: | ||
| total = total + val | ||
| return total |
There was a problem hiding this comment.
Suggested change
| total = 0 | |
| for val in resistors_in_series: | |
| total = total + val | |
| return total | |
| return sum(resistors_in_series) |
| @@ -0,0 +1,20 @@ | |||
| resistors_in_series = [100, 150, 330] | |||
There was a problem hiding this comment.
This is a test variable, so it should be inside the doctest
Suggested change
| resistors_in_series = [100, 150, 330] |
| """ | ||
| Calculate total resistance of resistors used in series | ||
|
|
||
| >>> calculate_resistence_in_series(resistors_in_series) |
There was a problem hiding this comment.
Suggested change
| >>> calculate_resistence_in_series(resistors_in_series) | |
| >>> calculate_resistence_in_series([100, 150, 330]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Add an algorithm to calculate the total resistance of resistors used in series
[x] Add an algorithm