Create collision_between_rectangles.py #7831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| "width": 30 | ||
| } | ||
|
|
||
| def check_collision(rect1, rect2) -> bool: |
There was a problem hiding this comment.
Please provide type hint for the parameter: rect1
Please provide type hint for the parameter: rect2
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| rect2 = {"x": 20, "y": 30, "height": 40, "width": 30} | ||
|
|
||
|
|
||
| def check_collision(rect1, rect2) -> bool: |
There was a problem hiding this comment.
Please provide type hint for the parameter: rect1
Please provide type hint for the parameter: rect2
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| rect2 = {"x": 20, "y": 30, "height": 40, "width": 30} | ||
|
|
||
|
|
||
| def check_collision(rect1 -> dict, rect2 -> dict) -> bool: |
There was a problem hiding this comment.
An error occured while parsing the file: maths/collision_between_rectangles.py
Traceback (most recent call last):
File "/opt/render/project/src/.venv/lib/python3.10/site-packages/libcst/_parser/base_parser.py", line 151, in _add_token
plan = stack[-1].dfa.transitions[transition]
KeyError: ReservedString(->)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 145, in parse
reports = lint_file(
libcst._exceptions.ParserSyntaxError: Syntax Error @ 6:27.
Incomplete input. Encountered '->', but expected ')'.
def check_collision(rect1 -> dict, rect2 -> dict) -> bool:
^
algorithms-keeper
bot
removed
the
tests are failing
cclauss
added
the
ON HOLD: Final hours of Hacktoberfest
CaedenPH
reviewed
Oct 31, 2022
Comment on lines
+1
to
+3
| rect1 = {"x": 10, "y": 10, "height": 30, "width": 50} | ||
|
|
||
| rect2 = {"x": 20, "y": 30, "height": 40, "width": 30} |
There was a problem hiding this comment.
These are not used within the actual code, so it should go within the if __name__ == "__main__" as test variables
| """ | ||
| Check if two rectangle are colliding/overlapping | ||
|
|
||
| >>> check_collision(rect1, rect2) |
There was a problem hiding this comment.
Test variables should go inside the doctest, not outside
cclauss
removed
the
ON HOLD: Final hours of Hacktoberfest
tianyizheng02
requested changes
Aug 1, 2023
|
Closing due to inactivity and lack of response to reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added algorithm to check collision between two rectangles
[x] Add an algorithm