Skip to content

Create collision_between_rectangles.py #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Create collision_between_rectangles.py #7831

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
585f631
Create collision_between_rectangles.py
0shuvo0 Oct 29, 2022
fd14a82
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 29, 2022
ad9f14b
Added parameter type hint
0shuvo0 Oct 29, 2022
c03713b
Fixed parameter type error
0shuvo0 Oct 29, 2022
7acd1ba
fixed a trype
0shuvo0 Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions maths/collision_between_rectangles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
rect1 = {"x": 10, "y": 10, "height": 30, "width": 50}

rect2 = {"x": 20, "y": 30, "height": 40, "width": 30}
Comment on lines +1 to +3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not used within the actual code, so it should go within the if __name__ == "__main__" as test variables



def check_collision(rect1, rect2) -> bool:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide type hint for the parameter: rect1

Please provide type hint for the parameter: rect2

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide type hint for the parameter: rect1

Please provide type hint for the parameter: rect2

"""
Check if two rectangle are colliding/overlaping

>>> check_collision(rect1, rect2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test variables should go inside the doctest, not outside

True
"""
x_bound = (
rect1["x"] < rect2["x"] + rect1["width"]
and rect1["x"] + rect2["width"] > rect2["x"]
)
y_bound = (
rect1["y"] < rect2["y"] + rect1["height"]
and rect1["height"] + rect1["y"] > rect2["y"]
)
return x_bound and y_bound


if __name__ == "__main__":
import doctest

doctest.testmod()