Skip to content

style: include legacy_numeric_constants #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jun 20, 2024

Pull Request Template

Description

This PR removes the legacy_numeric_constants from the list of suppressed lints. It was added in #754 to fix the failing CI.

Continuation of #743.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@vil02 vil02 requested a review from siriak June 20, 2024 15:17
@vil02 vil02 marked this pull request as ready for review June 20, 2024 15:20
@vil02 vil02 requested a review from imp2002 as a code owner June 20, 2024 15:20
@siriak siriak merged commit afdb283 into TheAlgorithms:master Jun 20, 2024
4 checks passed
@vil02 vil02 deleted the include_legacy_numeric_constants branch June 20, 2024 15:39
@vil02 vil02 mentioned this pull request Feb 27, 2025
7 tasks
@vil02 vil02 mentioned this pull request Apr 10, 2025
7 tasks
@vil02 vil02 mentioned this pull request May 31, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants