Skip to content

chore: suppress new clippy lints #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Apr 10, 2025

Pull Request Template

Description

This PR suppresses new clippy lints (cf. logs).

Similar to:

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@vil02 vil02 requested a review from imp2002 as a code owner April 10, 2025 06:24
@vil02 vil02 marked this pull request as draft April 10, 2025 06:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (b19c743) to head (f163277).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         317      317           
  Lines       22948    22948           
=======================================
  Hits        21916    21916           
  Misses       1032     1032           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 force-pushed the suppress_new_clippy_lints branch from fb96f99 to f163277 Compare April 10, 2025 06:26
@vil02 vil02 requested a review from siriak April 10, 2025 06:28
@vil02 vil02 marked this pull request as ready for review April 10, 2025 06:28
@siriak siriak merged commit a45a382 into TheAlgorithms:master Apr 10, 2025
4 checks passed
@vil02 vil02 deleted the suppress_new_clippy_lints branch April 11, 2025 05:07
@vil02 vil02 mentioned this pull request May 31, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants