Skip to content

chore: suppress new clippy warnings #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Dec 5, 2024

Pull Request Template

Description

This PR suppresses these new clippy warnings, which cause problems. Similar to

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (dadb978) to head (f8fb558).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
+ Coverage   95.39%   95.44%   +0.04%     
==========================================
  Files         316      316              
  Lines       22750    22750              
==========================================
+ Hits        21703    21713      +10     
+ Misses       1047     1037      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 force-pushed the supress_new_warnings branch from 369dbb8 to 896abae Compare December 5, 2024 06:50
@vil02 vil02 requested a review from siriak December 5, 2024 07:02
@vil02 vil02 marked this pull request as ready for review December 5, 2024 07:02
@vil02 vil02 requested a review from imp2002 as a code owner December 5, 2024 07:02
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit f66f836 into TheAlgorithms:master Dec 5, 2024
4 checks passed
@vil02 vil02 deleted the supress_new_warnings branch December 5, 2024 08:11
@vil02 vil02 mentioned this pull request Feb 27, 2025
7 tasks
@vil02 vil02 mentioned this pull request Apr 10, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants