Fix compatibility with ReScript 11 uncurried mode #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpyder
approved these changes
Apr 27, 2023
| @@ -336,6 +336,7 @@ module RequestInit = { | |||
| ~integrity: string="", | |||
| ~keepalive: option<bool>=?, | |||
| ~signal: option<signal>=?, | |||
| () | |||
There was a problem hiding this comment.
Pretty sure I left these () out because it was easier to write and wasn't necessary to make the output work, this is fine
| /* keys */ /* very experimental */ | ||
| @send external set: t => (string, string) => unit = "set" | ||
| @send external set: (t, string, string) => unit = "set" |
There was a problem hiding this comment.
I guess I inherited this from the bs-fetch code 🤨 this is totally fine 😂
|
@cknitt can you please run |
|
Done |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes to get this package to compile with ReScript 11 in uncurried mode.