Skip to content

Rescript 11 (WIP) #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Rescript 11 (WIP) #125

wants to merge 2 commits into from

Conversation

mvaled
Copy link
Contributor

@mvaled mvaled commented Jul 12, 2023

This PR shows that we can upgrade to the upcoming release of rescript.

We could even remove the only dev dependency; but it's not required.

@mvaled mvaled requested review from spocke and TheSpyder as code owners July 12, 2023 08:04
@TheSpyder
Copy link
Owner

That's good to know, thank you! I'm not yet sure what I want to do with ReScript 11, but it looks like uncurried: false is enough.

Many of these JS output changes are from ReScript 10, I haven't done any serious changes to webapi since that was released.

@mvaled
Copy link
Contributor Author

mvaled commented Jul 12, 2023

Hi @TheSpyder

I only created this PR because at first it gave me some issues.

Indeed, I'm not sure either if webapi benefits from the new things in Rescript 11. But it's good to know that it works with it; provided you set your project to "uncurried": false.

In the future, however, we might want to update it to adopt the new uncurried standard, so that projects be not required to set this flag. Otherwise, we might cause friction between the language and the library.

@TheSpyder
Copy link
Owner

I'm happy to add uncurried false to the bsconfig here, that's not a problem.

Support for uncurried mode is no simple task for this library. Some of the changes I'd like to do will make that easier, but it's a lot of work.

@mvaled
Copy link
Contributor Author

mvaled commented Jul 12, 2023

I'm not sure if that would work, i.e a project with "uncurried": true depending on a project that has it set to false. I could test this idea.

@TheSpyder
Copy link
Owner

I haven't tried either, but one of my other projects also depends on false - and parts of it actually don't work with false at the moment (I mentioned this to the devs but haven't logged a ticket for it yet).

@TheSpyder
Copy link
Owner

0.9.0 has been published, and I believe it works with uncurried mode thanks to #123

@TheSpyder TheSpyder closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants