Skip to content

Refactor settings in CLion plugin #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

EgorkaKulikov
Copy link
Collaborator

No description provided.

@EgorkaKulikov EgorkaKulikov requested a review from vol0n July 26, 2022 13:37
@EgorkaKulikov EgorkaKulikov force-pushed the egor/clion_settings_attempt_2 branch from 558e1c0 to 4575aa0 Compare July 26, 2022 14:07
@EgorkaKulikov EgorkaKulikov force-pushed the egor/clion_settings_attempt_2 branch from 829c4d8 to 26b1400 Compare July 26, 2022 14:34
Copy link
Member

@vol0n vol0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix one comment

@EgorkaKulikov EgorkaKulikov merged commit 60ae0c7 into vol0n/clion_plugin Jul 27, 2022
@sava-cska sava-cska deleted the egor/clion_settings_attempt_2 branch July 28, 2022 12:43
EgorkaKulikov added a commit that referenced this pull request Aug 12, 2022
* add content

* Refactor grpc related logic (#336)

* fix: logs on windows

* Refactor actions and their neighborhood (#346)

* Little improvements related to TODOs in code of CLion plugin (#351)

* Refactor settings in CLion plugin (#350)

* Skip coverage line indexes which are out of bounds

* rename client -> currentClient

* Add comments on initialization

* Refactor UI and Utils related logic (#357)

* Refactor some other pieces of code (#358)

* Add refresh action, show busy icon on refresh (#361)

* Improve some texts in CLion plugin (#362)

* Update readme.me file

* Update usage.md file

* Other corrections

* Little correction

* Fix: do not show canceled notification on error

* Fix: standalone coroutine exception canceled

* Fix: source folder view pane not working

* fix coverage

* Use noStateLoaded for state initialization

* fixes

* correct mark/unmark actions' names

* Refactor UTBotRunWithCoverageLineMarkerInfo

* Add button for local/wsl scenario, use spinners for int fields

* Bring all package names into line with naming requirements (#368)

* fix settings (#367)

* Fix: settings are not persisted, swap run icons

- when in Configurable we used: project.settings.storedSettings
it would return some instance of state. And because state
can change, writes to that instance were not saved and
so settings were not persisted
- Fixed a bug with test run icons, "Run all tests" was
swapped with "Run test"

* Do not use projectPath, use project.path

* fix: verbose mode enabling/disabling doesn't work

* show wizard on project open

* fix test dir setting

* remove custome target, persist selected target

* Little suggested changes

* Some improvements to targets

* fix: connectionSettingsChangedNotFired after settings changed

Co-authored-by: Egor Kulikov <[email protected]>

* use markDirtyAndRefresh (#371)

* Don't change directory status on double click

* Fix tests

* fix tests

* fix tests

* fix tests

* restore .vscode/settings.json

* restore .vscode/settings.json

* fix: with prompted result

* remove 'Detect path' button

* Remove local or wsl checkbox in settings

* change default build folder to 'build'

* add plugin artifact during publish-utbot workflow (#375)

* modify workflows to include clion artifact

* Use actions/setup-java for setting up jdk

* fix ci

* backup sarif report (#379)

* Backup sarif report

* backup sarif report

* Little code improvements

* handle one sarif report

Co-authored-by: Egor Kulikov <[email protected]>

* add run all tests and show coverage action (#378)

* Merge coverage

* Add action

* small fix

* small fix

* Update md files and icons (#381)

* remove dummy server

* remove workflows from IJ Platform template

* small fix

* fix with prompted result action

* fix blinking during generation

* change actions names in search, fix progress

* change vendor && notification group id

* fix defaults, fix notification group, use spinner

* disable timeout per function

* restore use stubs

Co-authored-by: Egor Kulikov <[email protected]>
Co-authored-by: Arseniy Volynets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants