fix settings #367
Merged
fix settings #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when in Configurable we used: project.settings.storedSettings it would return some instance of state. And because state can change, writes to that instance were not saved and so settings were not persisted - Fixed a bug with test run icons, "Run all tests" was swapped with "Run test"
EgorkaKulikov
approved these changes
Aug 4, 2022
EgorkaKulikov
added a commit
that referenced
this pull request
Aug 12, 2022
* add content * Refactor grpc related logic (#336) * fix: logs on windows * Refactor actions and their neighborhood (#346) * Little improvements related to TODOs in code of CLion plugin (#351) * Refactor settings in CLion plugin (#350) * Skip coverage line indexes which are out of bounds * rename client -> currentClient * Add comments on initialization * Refactor UI and Utils related logic (#357) * Refactor some other pieces of code (#358) * Add refresh action, show busy icon on refresh (#361) * Improve some texts in CLion plugin (#362) * Update readme.me file * Update usage.md file * Other corrections * Little correction * Fix: do not show canceled notification on error * Fix: standalone coroutine exception canceled * Fix: source folder view pane not working * fix coverage * Use noStateLoaded for state initialization * fixes * correct mark/unmark actions' names * Refactor UTBotRunWithCoverageLineMarkerInfo * Add button for local/wsl scenario, use spinners for int fields * Bring all package names into line with naming requirements (#368) * fix settings (#367) * Fix: settings are not persisted, swap run icons - when in Configurable we used: project.settings.storedSettings it would return some instance of state. And because state can change, writes to that instance were not saved and so settings were not persisted - Fixed a bug with test run icons, "Run all tests" was swapped with "Run test" * Do not use projectPath, use project.path * fix: verbose mode enabling/disabling doesn't work * show wizard on project open * fix test dir setting * remove custome target, persist selected target * Little suggested changes * Some improvements to targets * fix: connectionSettingsChangedNotFired after settings changed Co-authored-by: Egor Kulikov <[email protected]> * use markDirtyAndRefresh (#371) * Don't change directory status on double click * Fix tests * fix tests * fix tests * fix tests * restore .vscode/settings.json * restore .vscode/settings.json * fix: with prompted result * remove 'Detect path' button * Remove local or wsl checkbox in settings * change default build folder to 'build' * add plugin artifact during publish-utbot workflow (#375) * modify workflows to include clion artifact * Use actions/setup-java for setting up jdk * fix ci * backup sarif report (#379) * Backup sarif report * backup sarif report * Little code improvements * handle one sarif report Co-authored-by: Egor Kulikov <[email protected]> * add run all tests and show coverage action (#378) * Merge coverage * Add action * small fix * small fix * Update md files and icons (#381) * remove dummy server * remove workflows from IJ Platform template * small fix * fix with prompted result action * fix blinking during generation * change actions names in search, fix progress * change vendor && notification group id * fix defaults, fix notification group, use spinner * disable timeout per function * restore use stubs Co-authored-by: Egor Kulikov <[email protected]> Co-authored-by: Arseniy Volynets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing some setting in UI it was not saved to model