feat: replace guid with auth playerid for session management

Assets/BossRoom/Scripts/Client/Game/State/ClientMainMenuState.cs

@@ -6,9 +6,6 @@
 using Unity.Services.Core;
 using UnityEngine;
 
-#if UNITY_EDITOR
-using ParrelSync;
-#endif
 
 namespace Unity.Multiplayer.Samples.BossRoom.Client
 {
@@ -21,7 +18,6 @@ namespace Unity.Multiplayer.Samples.BossRoom.Client
     /// </remarks>
     public class ClientMainMenuState : GameStateBehaviour
     {
-        public const string AuthProfileCommandLineArg = "-AuthProfile";
         public override GameState ActiveState { get { return GameState.MainMenu; } }
 
         [SerializeField] GameObject[] m_GameObjectsThatWillBeInjectedAutomatically;
@@ -51,33 +47,11 @@ void InjectDependenciesAndInitialize(AuthenticationServiceFacade authServiceFaca
             m_Scope.BindInstanceAsSingle(m_IPUIMediator);
 
             var unityAuthenticationInitOptions = new InitializationOptions();
-
-#if UNITY_EDITOR
-            //The code below makes it possible for the clone instance to log in as a different user profile in Authentication service.
-            //This allows us to test services integration locally by utilising Parrelsync.
-            if (ClonesManager.IsClone())
-            {
-                Debug.Log("This is a clone project.");
-                var customArguments = ClonesManager.GetArgument().Split(',');
-
-                //second argument is our custom ID, but if it's not set we would just use some default.
-
-                var hardcodedProfileID = customArguments.Length > 1 ? customArguments[1] : "defaultCloneID";
-
-                unityAuthenticationInitOptions.SetProfile(hardcodedProfileID);
-            }
-#else
-            var arguments = System.Environment.GetCommandLineArgs();
-            for (int i = 0; i < arguments.Length; i++)
+            var profile = ProfileManager.Profile;
+            if (profile.Length > 0)
             {
-                if (arguments[i] == AuthProfileCommandLineArg)
-                {
-                    var profileId = arguments[i + 1];
-                    unityAuthenticationInitOptions.SetProfile(profileId);
-                    break;
-                }
+                unityAuthenticationInitOptions.SetProfile(profile);
             }
-#endif
 
             authServiceFacade.DoSignInAsync(OnAuthSignIn,  OnSignInFailed, unityAuthenticationInitOptions);
 

Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs

@@ -32,7 +32,7 @@ void ServiceErrorHandler(UnityServiceErrorMessage error)
                     // LobbyConflict can have multiple causes. Let's add other solutions here if there's other situations that arise for this.
                     errorMessage += "\nSee logs for possible causes and solution.";
                     Debug.LogError($"Got service error {error.Message} with LobbyConflict. Possible conflict cause: Trying to play with two builds on the " +
-                                   $"same machine. Please use command line arg '{ClientMainMenuState.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
+                                   $"same machine. Please use command line arg '{ProfileManager.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
                 }
             }
 
@@ -44,4 +44,4 @@ void OnDestroy()
             m_Subscriptions.Dispose();
         }
     }
-}
+}

Assets/BossRoom/Scripts/Client/com.unity.multiplayer.samples.bossroom.client.asmdef

@@ -12,8 +12,7 @@
         "Photon Realtime Transport for Netcode for GameObjects",
         "Unity.Services.Relay",
         "Unity.Multiplayer.Samples.Utilities",
-        "Unity.Services.Lobbies",
-        "ParrelSync"
+        "Unity.Services.Lobbies"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],
@@ -24,4 +23,4 @@
     "defineConstraints": [],
     "versionDefines": [],
     "noEngineReferences": false
-}
+}

Assets/BossRoom/Scripts/Shared/ClientPrefs.cs

@@ -7,10 +7,10 @@ namespace Unity.Multiplayer.Samples.BossRoom.Client
     /// (This is just a wrapper around the PlayerPrefs system,
     /// so that all the calls are in the same place.)
     /// </summary>
-    public class ClientPrefs
+    public static class ClientPrefs
     {
-        private const float k_DefaultMasterVolume = 0.5f;
-        private const float k_DefaultMusicVolume = 0.8f;
+        const float k_DefaultMasterVolume = 0.5f;
+        const float k_DefaultMusicVolume = 0.8f;
 
         public static float GetMasterVolume()
         {

Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ClientGameNetPortal.cs

@@ -1,6 +1,5 @@
 using System;
 using Unity.Multiplayer.Samples.BossRoom.Shared.Infrastructure;
-using Unity.Multiplayer.Samples.BossRoom.Shared.Net.UnityServices.Infrastructure;
 using Unity.Multiplayer.Samples.BossRoom.Shared.Net.UnityServices.Lobbies;
 using UnityEngine;
 using UnityEngine.SceneManagement;
@@ -18,6 +17,8 @@ public class ClientGameNetPortal : MonoBehaviour
         public static ClientGameNetPortal Instance;
         private GameNetPortal m_Portal;
 
+        string m_JoinCode;
+
         /// <summary>
         /// If a disconnect occurred this will be populated with any contextual information that was available to explain why.
         /// </summary>
@@ -155,11 +156,11 @@ private void OnDisconnectOrTimeout(ulong clientID)
         /// This method must be static because, when it is invoked, the client still doesn't know it's a client yet, and in particular, GameNetPortal hasn't
         /// yet initialized its client and server GNP-Logic objects yet (which it does in OnNetworkSpawn, based on the role that the current player is performing).
         /// </remarks>
-        /// <param name="portal"> </param>
         /// <param name="ipaddress">the IP address of the host to connect to. (currently IPV4 only)</param>
         /// <param name="port">The port of the host to connect to. </param>
         public void StartClient(string ipaddress, int port)
         {
+            m_Portal.OnlineMode = OnlineMode.IpHost;
             var chosenTransport = NetworkManager.Singleton.gameObject.GetComponent<TransportPicker>().IpHostTransport;
             NetworkManager.Singleton.NetworkConfig.NetworkTransport = chosenTransport;
 
@@ -177,40 +178,46 @@ public void StartClient(string ipaddress, int port)
                     throw new ArgumentOutOfRangeException(nameof(chosenTransport));
             }
 
-            ConnectClient();
+            ConnectClient(null);
         }
 
-        public async void StartClientUnityRelayModeAsync(string joinCode, Action<string> onFailure)
+        public void StartClientUnityRelayModeAsync(string joinCode, Action<string> onFailure)
         {
-            var utp = (UnityTransport)NetworkManager.Singleton.gameObject.GetComponent<TransportPicker>().UnityRelayTransport;
+            m_Portal.OnlineMode = OnlineMode.UnityRelay;
+            m_JoinCode = joinCode;
+            var utp = NetworkManager.Singleton.gameObject.GetComponent<TransportPicker>().UnityRelayTransport;
             NetworkManager.Singleton.NetworkConfig.NetworkTransport = utp;
 
             Debug.Log($"Setting Unity Relay client with join code {joinCode}");
 
-            try
-            {
-                var clientRelayUtilityTask =  UnityRelayUtilities.JoinRelayServerFromJoinCode(joinCode);
-                await clientRelayUtilityTask;
-                var (ipv4Address, port, allocationIdBytes, connectionData, hostConnectionData, key) = clientRelayUtilityTask.Result;
+            ConnectClient(onFailure);
+        }
 
-                m_LobbyServiceFacade.UpdatePlayerRelayInfoAsync(allocationIdBytes.ToString(), joinCode, null, null);
-                utp.SetClientRelayData(ipv4Address, port, allocationIdBytes, key, connectionData, hostConnectionData, isSecure: true);
-            }
-            catch (Exception e)
+        async void ConnectClient(Action<string> onFailure)
+        {
+            if (m_Portal.OnlineMode == OnlineMode.UnityRelay)
             {
-                onFailure?.Invoke(e.Message);
-                return;//not re-throwing, but still not allowing to connect
-            }
+                try
+                {
+                    var clientRelayUtilityTask =  UnityRelayUtilities.JoinRelayServerFromJoinCode(m_JoinCode);
+                    await clientRelayUtilityTask;
+                    var (ipv4Address, port, allocationIdBytes, connectionData, hostConnectionData, key) = clientRelayUtilityTask.Result;
 
-            ConnectClient();
-        }
+                    m_LobbyServiceFacade.UpdatePlayerRelayInfoAsync(allocationIdBytes.ToString(), m_JoinCode, null, null);
+                    var utp = (UnityTransport) NetworkManager.Singleton.NetworkConfig.NetworkTransport;
+                    utp.SetClientRelayData(ipv4Address, port, allocationIdBytes, key, connectionData, hostConnectionData, isSecure: true);
+                }
+                catch (Exception e)
+                {
+                    onFailure?.Invoke(e.Message);
+                    return;//not re-throwing, but still not allowing to connect
+                }
+
+            }
 
-        private void ConnectClient()
-        {
-            var clientGuid = ClientPrefs.GetGuid();
             var payload = JsonUtility.ToJson(new ConnectionPayload()
             {
-                clientGUID = clientGuid,
+                playerId = m_Portal.GetPlayerId(),
                 clientScene = SceneManager.GetActiveScene().buildIndex,
                 playerName = m_Portal.PlayerName
             });

Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/GameNetPortal.cs

@@ -5,6 +5,7 @@
 using Unity.Multiplayer.Samples.BossRoom.Shared.Net.UnityServices.Lobbies;
 using Unity.Netcode;
 using Unity.Netcode.Transports.UNET;
+using Unity.Services.Authentication;
 using UnityEngine;
 using UnityEngine.SceneManagement;
 
@@ -31,7 +32,7 @@ public enum OnlineMode
     [Serializable]
     public class ConnectionPayload
     {
-        public string clientGUID;
+        public string playerId;
         public int clientScene = -1;
         public string playerName;
     }
@@ -87,6 +88,8 @@ public class GameNetPortal : MonoBehaviour
         private LocalLobby m_LocalLobby;
         private LobbyServiceFacade m_LobbyServiceFacade;
 
+        public OnlineMode OnlineMode { get; set; }
+
         [Inject]
         private void InjectDependencies(LocalLobby localLobby, LobbyServiceFacade lobbyServiceFacade)
         {
@@ -166,6 +169,7 @@ private void OnNetworkReady()
         /// <param name="port">The port to connect to. </param>
         public void StartHost(string ipaddress, int port)
         {
+            OnlineMode = OnlineMode.IpHost;
             var chosenTransport = NetworkManager.Singleton.gameObject.GetComponent<TransportPicker>().IpHostTransport;
             NetworkManager.Singleton.NetworkConfig.NetworkTransport = chosenTransport;
 
@@ -188,6 +192,7 @@ public void StartHost(string ipaddress, int port)
 
         public async void StartUnityRelayHost()
         {
+            OnlineMode = OnlineMode.UnityRelay;
             var chosenTransport = NetworkManager.Singleton.gameObject.GetComponent<TransportPicker>().UnityRelayTransport;
             NetworkManager.Singleton.NetworkConfig.NetworkTransport = chosenTransport;
 
@@ -245,5 +250,27 @@ public void RequestDisconnect()
             SessionManager<SessionPlayerData>.Instance.OnUserDisconnectRequest();
             NetManager.Shutdown();
         }
+
+        public string GetPlayerId()
+        {
+            var playerId = "";
+            if (AuthenticationService.Instance.IsSignedIn)
+            {
+                playerId = AuthenticationService.Instance.PlayerId;
+            }
+            else if (OnlineMode == OnlineMode.IpHost)
+            {
+                playerId = ClientPrefs.GetGuid() + ProfileManager.Profile;
+            }
+            else if (OnlineMode == OnlineMode.UnityRelay)
+            {
+                Debug.LogError("OnlineMode set to UnityRelay, but not signed in through AuthenticationService.");
+            }
+            else
+            {
+                Debug.LogError($"OnlineMode not set to a valid value: {OnlineMode}");
+            }
+            return playerId;
+        }
     }
 }

Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ServerGameNetPortal.cs

@@ -146,7 +146,7 @@ private void ApprovalCheck(byte[] connectionData, ulong clientId, NetworkManager
             // Approval check happens for Host too, but obviously we want it to be approved
             if (clientId == NetworkManager.Singleton.LocalClientId)
             {
-                SessionManager<SessionPlayerData>.Instance.AddHostData(
+                SessionManager<SessionPlayerData>.Instance.SetupConnectingPlayerSessionData(clientId, m_Portal.GetPlayerId(),
                     new SessionPlayerData(clientId, m_Portal.PlayerName, m_Portal.AvatarRegistry.GetRandomAvatar().Guid.ToNetworkGuid(), 0, true));
 
                 connectionApprovedCallback(true, null, true, null, null);
@@ -176,9 +176,9 @@ private void ApprovalCheck(byte[] connectionData, ulong clientId, NetworkManager
 
             int clientScene = connectionPayload.clientScene;
 
-            Debug.Log("Host ApprovalCheck: connecting client GUID: " + connectionPayload.clientGUID);
+            Debug.Log("Host ApprovalCheck: connecting client with player ID: " + connectionPayload.playerId);
 
-            gameReturnStatus = SessionManager<SessionPlayerData>.Instance.SetupConnectingPlayerSessionData(clientId, connectionPayload.clientGUID,
+            gameReturnStatus = SessionManager<SessionPlayerData>.Instance.SetupConnectingPlayerSessionData(clientId, connectionPayload.playerId,
                 new SessionPlayerData(clientId, connectionPayload.playerName, m_Portal.AvatarRegistry.GetRandomAvatar().Guid.ToNetworkGuid(), 0, true))
                 ? ConnectStatus.Success
                 : ConnectStatus.LoggedInAgain;
@@ -187,7 +187,7 @@ private void ApprovalCheck(byte[] connectionData, ulong clientId, NetworkManager
             if (gameReturnStatus == ConnectStatus.LoggedInAgain)
             {
                 SessionPlayerData? sessionPlayerData =
-                    SessionManager<SessionPlayerData>.Instance.GetPlayerData(connectionPayload.clientGUID);
+                    SessionManager<SessionPlayerData>.Instance.GetPlayerData(connectionPayload.playerId);
 
                 ulong oldClientId = sessionPlayerData?.ClientID ?? 0;
                 // kicking old client to leave only current

Assets/BossRoom/Scripts/Shared/ProfileManager.cs

@@ -0,0 +1,59 @@
+using UnityEngine;
+
+#if UNITY_EDITOR
+using ParrelSync;
+#endif
+
+public static class ProfileManager
+{
+    public const string AuthProfileCommandLineArg = "-AuthProfile";
+
+    static bool s_IsProfileSet = false;
+
+    static string s_Profile = "";
+
+    public static string Profile
+    {
+        get
+        {
+            if (!s_IsProfileSet)
+            {
+                s_Profile = GetProfile();
+                s_IsProfileSet = true;
+            }
+
+            return s_Profile;
+        }
+        private set => s_Profile = value;
+    }
+
+    static string GetProfile()
+    {
+#if UNITY_EDITOR
+            //The code below makes it possible for the clone instance to log in as a different user profile in Authentication service.
+            //This allows us to test services integration locally by utilising Parrelsync.
+            if (ClonesManager.IsClone())
+            {
+                Debug.Log("This is a clone project.");
+                var customArguments = ClonesManager.GetArgument().Split(',');
+
+                //second argument is our custom ID, but if it's not set we would just use some default.
+
+                var hardcodedProfileID = customArguments.Length > 1 ? customArguments[1] : "defaultCloneID";
+
+                return hardcodedProfileID;
+            }
+#else
+        var arguments = System.Environment.GetCommandLineArgs();
+        for (int i = 0; i < arguments.Length; i++)
+        {
+            if (arguments[i] == AuthProfileCommandLineArg)
+            {
+                var profileId = arguments[i + 1];
+                return profileId;
+            }
+        }
+#endif
+        return "";
+    }
+}

Assets/BossRoom/Scripts/Shared/com.unity.multiplayer.samples.bossroom.shared.asmdef

@@ -12,7 +12,8 @@
         "Unity.Collections",
         "Photon Realtime Transport for Netcode for GameObjects",
         "Unity.Multiplayer.Samples.Utilities",
-        "Unity.Networking.Transport"
+        "Unity.Networking.Transport",
+        "ParrelSync"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],
@@ -23,4 +24,4 @@
     "defineConstraints": [],
     "versionDefines": [],
     "noEngineReferences": false
-}
+}