Skip to content

feat: replace guid with auth playerid for session management #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 14, 2022
Merged

feat: replace guid with auth playerid for session management #488

merged 32 commits into from
Mar 14, 2022

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Feb 24, 2022 •
edited
Loading

Description (*)

This PR replaces our custom GUID it with the PlayerId obtained from UGS's AuthenticationService when signed in. When not signed in, if using direct IP connection, it will use our custom GUID. It also removes the workaround we had to allow clients with the same GUID to connect on debug builds, since we are using profiles for that. Now the arguments used to set profiles are also used to update our custom GUID when connecting to a host to differentiate each client if using multiple builds or parrelsync clones.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2640

Manual testing scenarios

  1. Start a game with two or more clients
  2. Disconnect each client
  3. Reconnect to the game with each client
  4. See that each client is reconnected with the right character and the right data
  5. Do it again through direct IP while signed in and not signed in.

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added the 1-Needs Review PR needs attention from the assignee and reviewers label Feb 24, 2022
This was referenced Mar 7, 2022
Merged
Merged
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) March 7, 2022 19:50
LukeStampfli
LukeStampfli previously approved these changes Mar 8, 2022
View reviewed changes
netcode-ci-service and others added 13 commits March 8, 2022 18:47
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
020cce1
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
0d874b5
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
77b939f
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
b974e90
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
2d83fcf
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
5296213
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
1babc3f
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
8975d19
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
40d2f89
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
f13fd7a
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
6f27732
@LPLafontaineB
Revert "Removed guid from ClientPrefs"
0d34e9c 
This reverts commit 3d9ebfa.
@netcode-ci-service
Merge develop into feature/replace-guid-with-auth-playerid
4063c42
@LPLafontaineB LPLafontaineB marked this pull request as draft March 11, 2022 14:25
auto-merge was automatically disabled March 11, 2022 14:25

Pull request was converted to draft

@LPLafontaineB LPLafontaineB marked this pull request as ready for review March 11, 2022 15:31
SamuelBellomo
SamuelBellomo previously approved these changes Mar 11, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB requested a review from pdeschain March 11, 2022 21:25
fernando-cortez
fernando-cortez reviewed Mar 11, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 11, 2022
@SamuelBellomo SamuelBellomo added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 11, 2022
@LPLafontaineB LPLafontaineB merged commit 46e2cef into develop Mar 14, 2022
@LPLafontaineB LPLafontaineB deleted the feature/replace-guid-with-auth-playerid branch March 14, 2022 13:40
LPLafontaineB added a commit that referenced this pull request Mar 14, 2022
@LPLafontaineB
feat: replace guid with auth playerid for session management (#488)
4acbddb 
* Replaced custom guid with playerid for session management when signed in through UGS's Authentication Service

* Removed code handling duplicate connections in debug builds

* When not using UGS, player id is now defined as GUID + profile string

(cherry picked from commit 46e2cef)
@LPLafontaineB LPLafontaineB mentioned this pull request Mar 14, 2022
Merged
4 tasks
SamuelBellomo pushed a commit that referenced this pull request Mar 14, 2022
@LPLafontaineB
feat: replace guid with auth playerid for session management (#488) (#…
45a1d04 
…548)

* Replaced custom guid with playerid for session management when signed in through UGS's Authentication Service

* Removed code handling duplicate connections in debug builds

* When not using UGS, player id is now defined as GUID + profile string

(cherry picked from commit 46e2cef)
SamuelBellomo added a commit that referenced this pull request Mar 14, 2022
@SamuelBellomo
Merge branch 'release/GDC2022' into sam/fix/some-cleanup-cherrypick
72bfd1d 
* release/GDC2022:
  feat: authentication failure message popups will tell the user to try direct ip connection option (#547)
  feat: replace guid with auth playerid for session management (#488) (#548)

# Conflicts:
#	Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs
SamuelBellomo added a commit that referenced this pull request Mar 14, 2022
@SamuelBellomo
Merge branch 'release/GDC2022' into sam/fix/workaround-loading-screen…
e44d423 
…-not-going-away

* release/GDC2022:
  fix: leaving lobby when disconnecting (#515)
  better error messages and lobby fix (#550)
  feat: authentication failure message popups will tell the user to try direct ip connection option (#547)
  feat: replace guid with auth playerid for session management (#488) (#548)

# Conflicts:
#	Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ClientGameNetPortal.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@LukeStampfli LukeStampfli Awaiting requested review from LukeStampfli

@pdeschain pdeschain Awaiting requested review from pdeschain

Assignees

@SamuelBellomo SamuelBellomo

@fernando-cortez fernando-cortez

Labels
3-Good to Merge GDC-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LPLafontaineB @LukeStampfli @SamuelBellomo @fernando-cortez @netcode-ci-service