feat: authentication failure message popups will tell the user to try direct ip connection option #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
showing the error message along with a tip - the user can always use direct ip option to connect
due to the fact that auth service can emit exceptions of multiple types - to avoid missing a handler
pdeschain
added
2-Easy
SamuelBellomo
previously approved these changes
Mar 11, 2022
fernando-cortez
previously approved these changes
Mar 11, 2022
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
LPLafontaineB
previously approved these changes
Mar 11, 2022
…tiplayer.samples.coop into pdeschain/better-offline-flow # Conflicts: # Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs
pdeschain
dismissed stale reviews from LPLafontaineB, fernando-cortez, and SamuelBellomo
via
3788107
LPLafontaineB
approved these changes
Mar 14, 2022
SamuelBellomo
approved these changes
Mar 14, 2022
pdeschain
added a commit
that referenced
this pull request
Mar 14, 2022
… direct ip connection option (#547) * Moved service error popup logic to dedicated class * better error message handling for authentication errors showing the error message along with a tip - the user can always use direct ip option to connect * using a more general type of exception due to the fact that auth service can emit exceptions of multiple types - to avoid missing a handler # Conflicts: # Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs
SamuelBellomo
added a commit
that referenced
this pull request
Mar 14, 2022
…-not-going-away * release/GDC2022: fix: leaving lobby when disconnecting (#515) better error messages and lobby fix (#550) feat: authentication failure message popups will tell the user to try direct ip connection option (#547) feat: replace guid with auth playerid for session management (#488) (#548) # Conflicts: # Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ClientGameNetPortal.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR moves the logic for spawning popup windows with various service errors under one roof -
UnityServicesUIHandlerIt also changes the message that's displayed for Authentication service issues that is in my opinion more informative. It also directs users to go and use Direct IP option if they need to.
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s):
MTT-2315 - https://jira.unity3d.com/browse/MTT-2315
Manual testing scenarios
Questions or comments
Contribution checklist