feat: popup panel for connection status messages #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPLafontaineB
added
1-Needs Review
SamuelBellomo
previously approved these changes
Mar 1, 2022
Assets/BossRoom/Scripts/Client/UI/ConnectionStatusMessageUIManager.cs
Outdated
Show resolved
Hide resolved
SamuelBellomo
previously approved these changes
Mar 1, 2022
LPLafontaineB
added
2-One More Review
SamuelBellomo
previously approved these changes
Mar 2, 2022
SamuelBellomo
previously approved these changes
Mar 3, 2022
SamuelBellomo
approved these changes
Mar 3, 2022
SamuelBellomo
added
the
0-URGENT
fernando-cortez
approved these changes
Mar 4, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
LPLafontaineB
added a commit
that referenced
this pull request
Mar 4, 2022
* Added basic popup panel for connection status and auth errors * Added a message channel for ConnectionStatus * Created manager to handle connection status messages * Displaying new messages to console if popup window is already in use (cherry picked from commit df31161)
4 tasks
SamuelBellomo
pushed a commit
that referenced
this pull request
Mar 4, 2022
* Added basic popup panel for connection status and auth errors * Added a message channel for ConnectionStatus * Created manager to handle connection status messages * Displaying new messages to console if popup window is already in use (cherry picked from commit df31161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR adds a simple reusable popup panel that lives in the SettingsPanelCanvas inside the DontDestroyOnLoadScene and uses it to display messages to players related to connection status. Connection status messages are now published through a new message channel instead of being handled by LobbyUIMediator. Finally, a manager is added, which subscribes to this message channel and calls the PopupPanel when needed.
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT-2677
Manual testing scenarios
Questions or comments
Contribution checklist