feat: popup panel stacking #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a message channel for ConnectionStatus
LPLafontaineB
added
2-Easy
LPLafontaineB
added
4-On Hold
|
Put on hold as it is not needed for GDC |
* Removed the stack in PopupPanel and replaced it with a list of PopupPanels in PopupManager * PopupPanel now only represents an actual popup * When calling PopupManager, it will instantiate or reuse previous instances of the PopupPanel prefab to display the popup
LPLafontaineB
added
1-Needs Review
|
tested on my phone with a 20:9 ratio and 720x1600 resolution (both in portrait and landscape orientations) with enough popups stacked to reach the maximum popup offset and they all were still visible in the screen. |
SamuelBellomo
previously approved these changes
Mar 29, 2022
pdeschain
reviewed
Apr 5, 2022
|
Apart from the DI comment - this PR is 👍 |
SamuelBellomo
previously approved these changes
Apr 5, 2022
4 tasks
SamuelBellomo
approved these changes
Apr 6, 2022
pdeschain
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR simplifies PopupPanel so its only responsibility is to display a single message. It moves the responsibility of creating those messages to the PopupManager. The PopupManager will instantiate PopupPanel gameObjects and display them when it is called. It will reuse those instantiated objects when possible (which is most of the time since we likely won't display more than one or two at once in a regular case).
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT2733
Manual testing scenarios
The simplest way to see this PR's effects is to duplicate calls to ShowPopupPanel() to have multiple popups at once. Or add a coroutine that perdically calls this, so that you can experiment with closing some of them before new ones are created.
Questions or comments
Contribution checklist