Skip to content

fix: not returning to mainmenu when reconnect fails #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Mar 9, 2022

Description (*)

This PR does three things: first it adds null checks to prevent null reference exceptions, then it adds a mechanism for the host to tell the clients when it voluntarily quits a game, so that if they quit using the in-game quit button, they will not attempt to reconnect and simply display a message instead. Finally, it reduces the number of reconnection attempts to 1 to avoid an issue that seems linked to Relay, until further investigation allows us to better understand that bug (see MTT-2794 for details)

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2786 and MTT-2795

Manual testing scenarios

  1. Start a game as a host
  2. Join with a client
  3. With the host, leave the session via the in-game quit button
  4. See the client is disconnected and returned to the main menu and doesn't try to reconnect
  5. Start another game with a host and client
  6. End the play mode if in editor or quit the application if using a build (not via the in-game quit button)
  7. See the client attempting to reconnect, then failing and going back to the main menu

Questions or comments

On hold because will have to wait until #523 is merged first, as this is depending on a fix introduced by this other PR.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. 1-Needs Review PR needs attention from the assignee and reviewers 0-workaround labels Mar 9, 2022
@SamuelBellomo
Copy link
Contributor

there's a few things that shouldn't be workarounds though, no? Only the 1 reconnect attempt limit should be a workaround?

@SamuelBellomo SamuelBellomo added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 9, 2022
@LPLafontaineB
Copy link
Contributor Author

there's a few things that shouldn't be workarounds though, no? Only the 1 reconnect attempt limit should be a workaround?

Auto-reconnect as a whole was flagged as a workaround though and will not be in develop until pre.7 which should have the fix needed to remove the workaround auto-reconnect used

SamuelBellomo
SamuelBellomo previously approved these changes Mar 9, 2022
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers and removed 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. 2-Reviewed with Comments PR requires owner's attention labels Mar 10, 2022
@LPLafontaineB LPLafontaineB merged commit ef6fd8c into release/GDC2022 Mar 10, 2022
@LPLafontaineB LPLafontaineB deleted the fix/not-returning-to-mainmenu-when-reconnect-fails branch March 10, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-workaround 1-Needs Review PR needs attention from the assignee and reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants