-
Notifications
You must be signed in to change notification settings - Fork 560
fix: not returning to mainmenu when reconnect fails #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not returning to mainmenu when reconnect fails #532
Conversation
…loading main menu
…e being no longer connected
Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/GameNetPortal.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ServerGameNetPortal.cs
Show resolved
Hide resolved
there's a few things that shouldn't be workarounds though, no? Only the 1 reconnect attempt limit should be a workaround? |
Auto-reconnect as a whole was flagged as a workaround though and will not be in develop until pre.7 which should have the fix needed to remove the workaround auto-reconnect used |
Description (*)
This PR does three things: first it adds null checks to prevent null reference exceptions, then it adds a mechanism for the host to tell the clients when it voluntarily quits a game, so that if they quit using the in-game quit button, they will not attempt to reconnect and simply display a message instead. Finally, it reduces the number of reconnection attempts to 1 to avoid an issue that seems linked to Relay, until further investigation allows us to better understand that bug (see MTT-2794 for details)
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT-2786 and MTT-2795
Manual testing scenarios
Questions or comments
On hold because will have to wait until #523 is merged first, as this is depending on a fix introduced by this other PR.
Contribution checklist