Skip to content

fix: postgame menu button #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2022
Merged

fix: postgame menu button #523

merged 2 commits into from
Mar 9, 2022

Conversation

LukeStampfli
Copy link
Contributor

Description (*)

Fixes a bug where pressing the "return to menu" button in the post game screen did not do anything when pressing the button. A repeated (2nd) press of the button would correctly load the menu scene.

When returning to the menu from the post game scene the active lobby was not quit so the lobby list still showed 2/6 players and did not allow the client to join the lobby again.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2791

Manual testing scenarios

  • Build and run a host (create a lobby session)
  • Run a client in editor and join the host.
  • Select characters and press ready
  • Use the cheat window to go to the post game lobby
  • Press the "return to menu" button on the client

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LukeStampfli LukeStampfli added GDC-cherrypick 1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly labels Mar 9, 2022
LukeStampfli
LukeStampfli commented Mar 9, 2022
View reviewed changes
LukeStampfli
LukeStampfli commented Mar 9, 2022
View reviewed changes
@LukeStampfli
Copy link
Contributor Author

#515 Seems to address similar issues in regards to quitting lobby @LPLafontaineB 👀

LPLafontaineB
LPLafontaineB previously approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@LPLafontaineB LPLafontaineB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to be cherrypicked to develop though, since the bug is introduced by the loading screen which won't be merged to develop until the next NGO release

fernando-cortez
fernando-cortez reviewed Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick aside, lgtm.

@LukeStampfli
Copy link
Contributor Author

Switched to workaround instead of cherry pick since this seems to be introduced by our latest loading screen work as mentioned above by @LPLafontaineB

LukeStampfli
LukeStampfli commented Mar 9, 2022
View reviewed changes
LukeStampfli
LukeStampfli commented Mar 9, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 9, 2022
@LPLafontaineB LPLafontaineB mentioned this pull request Mar 9, 2022
Merged
4 tasks
@SamuelBellomo SamuelBellomo added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 9, 2022
@SamuelBellomo SamuelBellomo merged commit 9e68691 into release/GDC2022 Mar 9, 2022
@SamuelBellomo SamuelBellomo deleted the fix/postgame-menu-button branch March 9, 2022 22:55
SamuelBellomo added a commit that referenced this pull request Mar 10, 2022
@SamuelBellomo
Merge branch 'release/GDC2022' into sam/fix/adding-transport-RTT-to-U…
761c691 
…I-stats

* release/GDC2022:
  added IP button to main menu (#535)
  fix: postgame menu button (#523)
  chore: adding leak detect (#492)
  Cherry pick: lobby blue banner fix, mainmenu.unity scene merge conflict resolved with unity merge tool (#534)
  Filled in some holes in the floor (#527) (#533)
  fix: populate lobby room name if creation room input field is empty (#522)
  lobby fix: Adding instructions when we get a service error on conflicting joins (#511)
  feat: auto reconnect (#513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Assignees
No one assigned
Labels
0-workaround 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukeStampfli @SamuelBellomo @fernando-cortez @LPLafontaineB