Skip to content

Fix: Holes in Floor #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Fix: Holes in Floor #527

merged 2 commits into from
Mar 9, 2022

Conversation

jilfranco-unity
Copy link
Contributor

Description (*)

Filled in some holes in the floor and rebaked lighting. Should be in both develop and GDC branches. Marking urgent since there really shouldn't be holes in our floors 😬

Before:
image

After:
image

Before:
image

After:
image

Before:
image

After:
image

@jilfranco-unity jilfranco-unity added 0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 9, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 9, 2022
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 9, 2022
@jilfranco-unity jilfranco-unity merged commit 59434fd into develop Mar 9, 2022
@jilfranco-unity jilfranco-unity deleted the fix/holes-in-floor branch March 9, 2022 19:02
jilfranco-unity added a commit that referenced this pull request Mar 9, 2022
SamuelBellomo pushed a commit that referenced this pull request Mar 9, 2022
SamuelBellomo added a commit that referenced this pull request Mar 10, 2022
…I-stats

* release/GDC2022:
  added IP button to main menu (#535)
  fix: postgame menu button (#523)
  chore: adding leak detect (#492)
  Cherry pick: lobby blue banner fix, mainmenu.unity scene merge conflict resolved with unity merge tool (#534)
  Filled in some holes in the floor (#527) (#533)
  fix: populate lobby room name if creation room input field is empty (#522)
  lobby fix: Adding instructions when we get a service error on conflicting joins (#511)
  feat: auto reconnect (#513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge GDC-cherrypick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants