fix: hard coding frame rate #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… off about 1/3 of CPU usage when running 2 builds on the same machine
SamuelBellomo
added
0-URGENT
SamuelBellomo
requested review from
pdeschain,
fernando-cortez,
jilfranco-unity and
LPLafontaineB
There was a problem hiding this comment.
Tested on a pixel 3, which has a refresh rate of 60 Hz, and this was playing nicely, mostly since it gets capped at 60.
Per the docs on targetFrameRate, it is usually defaulted to 30 Hz on mobile devices. Pixel 6 will have a 90 Hz refresh rate, but I feel like you'll see diminishing returns with that so high. Capping this to 60 on mobile devices I think should be enough.
SamuelBellomo
added a commit
that referenced
this pull request
Mar 18, 2022
…ch, but still shaves off about 1/3 of CPU usage when running 2 builds on the same machine (#573)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
setting to 120 so it doesn't influence RTT too much, but still shaves off about 1/3 of CPU usage when running 2 builds on the same machine
We'll need to test this on Android, make sure this doesn't mess things up. @fernando-cortez @jilfranco-unity if one of you guys could test it on your devices, that'd be great :)