-
Notifications
You must be signed in to change notification settings - Fork 557
chore: adding optional pre-commit hooks [MTT-3302] #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
de619af
initial pass at hooks
SamuelBellomo 0aa9a40
Adding project id detection
SamuelBellomo 65ec34f
something didn't work, reverting file
SamuelBellomo 2ae194a
adding git lfs support
SamuelBellomo 709ebcc
cleanup
SamuelBellomo 7ef0994
fix for windows
SamuelBellomo fad73ef
Merge develop into sam/feat/pre-commit-hook
netcode-ci-service File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
echo "starting" | ||
xcopy pre-commit.toInstall ../.git/hooks/pre-commit | ||
echo "checking if python is installed, if the following errors out, please install python3" | ||
python3 -c "print('done installing')" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
echo "starting" | ||
cp pre-commit.toInstall ../.git/hooks/pre-commit | ||
chmod +x ../.git/hooks/pre-commit | ||
echo "checking if python is installed, if the following errors out, please install python3" | ||
|
||
python3 -c "print('done installing')" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import json | ||
import sys | ||
import os | ||
import re | ||
|
||
def FailCommit(reason): | ||
print("Oh no! Bad commit! "+reason) | ||
sys.exit(1) | ||
|
||
def GetStagedFileContent(filePath): | ||
cmd = 'git show :' + filePath | ||
stream = os.popen(cmd) | ||
return stream.read() | ||
|
||
def GetLFSStagedFileContent(filePath): | ||
cmd = f"git cat-file blob :{filePath} | git lfs smudge" | ||
stream = os.popen(cmd) | ||
return stream.read() | ||
|
||
output = GetStagedFileContent('Packages/manifest.json') | ||
packages = json.loads(output)['dependencies'] | ||
if ('com.unity.multiplayer.virtualprojects' in packages): | ||
FailCommit("Virtual projects in packages") | ||
if ('github' in packages['com.unity.multiplayer.tools'].lower()): | ||
FailCommit("Tools using github package") | ||
|
||
content = GetLFSStagedFileContent('ProjectSettings/ProjectSettings.asset') | ||
res = re.search(r'.*cloudProjectId:.*\w+\s*\n', content) != None | ||
if res: | ||
FailCommit("Detected cloud project id in project settings") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
#!/bin/sh | ||
python3 RepoUtilities/pre-commit.py | ||
SamuelBellomo marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.