Skip to content

chore: adding optional pre-commit hooks [MTT-3302] #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 20, 2022
Merged

chore: adding optional pre-commit hooks [MTT-3302] #619

merged 7 commits into from
Apr 20, 2022

Conversation

SamuelBellomo
Copy link
Contributor

Description

Adding pre-commit hooks to help keep bad things away. These will fail your commits if you're trying to include project IDs or black listed packages.
To install those, run the install script from the RepoUtilities folder.
Not tested on Windows yet.

Issue Number(s)

MTT-3302

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@SamuelBellomo SamuelBellomo added the 1-Needs Review PR needs attention from the assignee and reviewers label Apr 14, 2022
@SamuelBellomo
Copy link
Contributor Author

This is part 1 of a series of PRs

@SamuelBellomo SamuelBellomo enabled auto-merge (squash) April 19, 2022 21:30
bendoyon
bendoyon previously approved these changes Apr 20, 2022
View reviewed changes
LPLafontaineB
LPLafontaineB reviewed Apr 20, 2022
View reviewed changes
becksebenius-unity
becksebenius-unity reviewed Apr 20, 2022
View reviewed changes
@SamuelBellomo SamuelBellomo merged commit ef83c56 into develop Apr 20, 2022
@SamuelBellomo SamuelBellomo deleted the sam/feat/pre-commit-hook branch April 20, 2022 18:57
SamuelBellomo added a commit that referenced this pull request Apr 20, 2022
@SamuelBellomo
Merge branch 'develop' into feature/bump-2021
187a4a6 
* develop:
  chore: adding optional pre-commit hooks [MTT-3302] (#619)
  chore: Updated readme links to the doc site from doc restructure with Fatih. (#622)

# Conflicts:
#	RepoUtilities/pre-commit.toInstall
SamuelBellomo added a commit that referenced this pull request Apr 20, 2022
@SamuelBellomo
Merge branch 'feature/bump-2021' into feature/bump-2021-feat/RNSM-dog…
3df0a12 
…fooding

* feature/bump-2021:
  Anything under ProjectSettings should be versioned.
  bumping to latest LTS
  chore: adding optional pre-commit hooks [MTT-3302] (#619)
  chore: Updated readme links to the doc site from doc restructure with Fatih. (#622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becksebenius-unity becksebenius-unity becksebenius-unity approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@pdeschain pdeschain Awaiting requested review from pdeschain

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

@jilfranco-unity jilfranco-unity Awaiting requested review from jilfranco-unity

@bendoyon bendoyon Awaiting requested review from bendoyon

Assignees
No one assigned
Labels
1-Needs Review PR needs attention from the assignee and reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SamuelBellomo @bendoyon @becksebenius-unity @fernando-cortez @LPLafontaineB @netcode-ci-service