feat: Allow reliable sends to go over maximum payload size #2081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1148,14 +1148,14 @@ public override NetcodeNetworkEvent PollEvent(out ulong clientId, out ArraySegme | |||
| /// <param name="networkDelivery">The delivery type (QoS) to send data with</param> | |||
| public override void Send(ulong clientId, ArraySegment<byte> payload, NetworkDelivery networkDelivery) | |||
| { | |||
| if (payload.Count > m_MaxPayloadSize) | |||
| var pipeline = SelectSendPipeline(networkDelivery); | |||
NoelStephensUnity
approved these changes
Jul 26, 2022
cdmazom
approved these changes
Jul 26, 2022
SamuelBellomo
added a commit
to Unity-Technologies/com.unity.multiplayer.samples.coop
that referenced
this pull request
Jul 26, 2022
…everting MaxPayloadSize to default
8 tasks
SamuelBellomo
added a commit
to Unity-Technologies/com.unity.multiplayer.samples.coop
that referenced
this pull request
Oct 25, 2022
* After this PR Unity-Technologies/com.unity.netcode.gameobjects#2081 reverting MaxPayloadSize to default * basis works, still need to debug issue with client reconnecting a second time * setting back max payload size to default value. With recent changes, this now only applies to unreliable messages. With how little NGO uses unreliable messages, this shouldn't need any tweaking anymore. reserializing NetworkingManager, this removes the old max send queue size value as well. * Increasing connection approval timeout to 5 seconds, as 1 second was pretty short for a connection. If there's any packet drops or temporary lag spike, this could timeout the connection when it was actually fine. Still lower than the default 10 seconds. * using classes instead of structs now that we have managed types available in netvars * fixing null ref when doing reconnection flow * deprecated note for utilities * updating manifest and dependencies with 1.1.0 now it's released * initializing number of reconnect attempts before starting the reconnect coroutine * fixing player prefab being destroyed issue Co-authored-by: Unity Netcode CI <[email protected]> Co-authored-by: LPLafontaineB <[email protected]>
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…hnologies#2081) * feat: Allow reliable sends to go over maximum payload size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Max Payload Size' setting in
UnityTransportdetermines the largest payload that can be sent in a singleSendcall. Internally, we use this value to configure the fragmentation limit in UTP's fragmentation pipeline stage. This pipeline stage is only used for unreliable traffic, though. Fragmentation of reliable traffic is done directly in the send/receive queues insideUnityTransport.So technically, reliable payload size is not bound by that 'Max Payload Size' limit (it's bound by 'Max Send Queue Size' instead). Still,
UnityTransport.Sendwould reject reliable sends larger than 'Max Payload Size' to remain consistent with the unreliable behavior. This PR changes this behavior and now allows reliable sends to go over the configured maximum payload size.The reason for this change is that it's now apparent (from browsing Discord and the forums) that tweaking this maximum payload size limit is a source of friction for users. Since most traffic in NGO is reliable, this PR will make it look to most users as if the limit doesn't exist. (Remains the issue of having to tweak the 'Max Send Queue Size', but solving that is a bit more complicated.)
Changelog
UnityTransport, reliable payloads are now allowed to exceed the configured 'Max Payload Size'. Unreliable payloads remain bounded by this setting.Testing and Documentation