fix: Removing extra bracket in UnityTransport #2253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluong6
changed the title
simon-lemay-unity
approved these changes
Oct 13, 2022
This reverts commit d7f9296.
| @@ -1474,7 +1474,7 @@ public void SetClientSecrets(string serverCommonName, string caCertificate = nul | |||
| } | |||
| else | |||
| { | |||
| m_NetworkSettings.WithSecureClientParameters(m_ClientCaCertificate, m_ServerCommonName)); | |||
| m_NetworkSettings.WithSecureClientParameters(m_ClientCaCertificate, m_ServerCommonName); | |||
There was a problem hiding this comment.
Ugh. How did that slip by ? :-)
There was a problem hiding this comment.
Probably a typo on my end when I updated to the new string-based APIs. I hadn't realized that encryption support was behind the UTP 2.0 define, so hadn't thought of trying to compile with that installed.
jeffreyrainy
approved these changes
Oct 13, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
* removing extra bracket * adding tmp commit to pass the semantic pull request check * Revert "adding tmp commit to pass the semantic pull request check" This reverts commit d7f9296.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an extra bracket in the else statement when we set the client security parameters.
Changelog
None
Testing and Documentation