fix: NetworkVariables with NetworkVariableUpdateTraits can cause other NetworkVariables to drop changes (up-port) #3466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
changed the title
EmandM
approved these changes
May 28, 2025
Use the authorityComponent's NetworkManager to avoid exception during DA service tests.
NoelStephensUnity
added a commit
that referenced
this pull request
May 28, 2025
…r NetworkVariables to drop changes (#3465) This PR resolves an issue where a `NetworkBehaviour` with multiple `NetworkVariables` could drop changes if one of the `NetworkVariables` has unique `NetworkVariableUpdateTraits` set, is dirty, but is not ready to send. Based on user @khyperia's submission #3462. ## Changelog - Fixed: issue where `NetworkVariable`s on a `NetworkBehaviour` could fail to synchronize changes if one has `NetworkVariableUpdateTraits` set and is dirty but is not ready to send. ## Testing and Documentation - Includes integration test `NetworkVariableTraitsTests.WhenNonTraitsIsDirtyButTraitsIsNotReadyToSend`. - No documentation changes or additions were necessary. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport This required and up-port to v2.x (#3466) --------- Co-authored-by: khyperia <[email protected]>
NoelStephensUnity
deleted the
fix/netvar-dropping-changes-khyperia-up-port
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where a
NetworkBehaviourwith multipleNetworkVariablescould drop changes if one of theNetworkVariableshas uniqueNetworkVariableUpdateTraitsset, is dirty, but is not ready to send.Based on user @khyperia's submission #3462.
Changelog
NetworkVariables on aNetworkBehaviourcould fail to synchronize changes if one hasNetworkVariableUpdateTraitsset and is dirty but is not ready to send.Testing and Documentation
NetworkVariableTraitsTests.WhenNonTraitsIsDirtyButTraitsIsNotReadyToSend.Backport
This is an up-port of #3465