Skip to content

[refactor] Allow full RunOptions to be specified in trainer configuration YAML #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Apr 30, 2020
Merged

[refactor] Allow full RunOptions to be specified in trainer configuration YAML #3815

merged 45 commits into from
Apr 30, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Apr 21, 2020

Proposed change(s)

Rather than have the YAML stored as part of RunOptions, make the YAML a representation of RunOptions, including engine options and other parameters. Anything not specified in the YAML config will be set to the default values; anything specified in the CLI will override values found in the YAML.

This removes the need for a separate run_experiment entry point.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Ervin Teng added 26 commits April 13, 2020 18:47
Move sampler config into main YAML
a2b4fb7
Make CLI override YAML
94c684c
Bring back default functionality, curriculum loader
54e9914
Load curriculum from same YAML
df4a358
Example WallJump curriculum
3a84c13
New-format YAML files
92c9682
Fix walljump curriculum
9dcf38d
Commit SAC parameters
a926d4c
Delete old configs and add gail
419a156
Change some of the documentation
c80c359
Merge master into develop-single-config
f020ecc
More doc updates
0fa8f8b
Fix Yamato test
72b39f0
Fix learn.py test
0c89258
More docs updates
b84396f
Update migrating.md file
756a75f
Update changelog and improve migrating
cb97315
Don't hard break trying to get curriculum out of bad config
7bb6366
Use behavior name instead of brain
e0b8c9c
Fix yamato_utils
8d37045
Merge branch 'master' of github.com:Unity-Technologies/ml-agents into…
b20ab5d 
… develop-single-config
Delete curricula
50eafc2
Merge branch 'master' of github.com:Unity-Technologies/ml-agents into…
cf920b6 
… develop-single-config
Make RunOptions and YAML compatible
eb3df94
Use entire YAML as run options, and override via CLI
690da4a
Add test
3c26e57
@ervteng ervteng requested a review from harperj April 21, 2020 00:45
ervteng
ervteng commented Apr 21, 2020
View reviewed changes
harperj
harperj reviewed Apr 22, 2020
View reviewed changes
harperj
harperj reviewed Apr 22, 2020
View reviewed changes
@ervteng ervteng mentioned this pull request Apr 23, 2020
Merged
10 tasks
harperj
harperj reviewed Apr 29, 2020
View reviewed changes
@ervteng ervteng changed the base branch from develop-single-config to master April 29, 2020 23:27
@ervteng ervteng merged commit 383de98 into master Apr 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-default-overrides branch April 30, 2020 00:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harperj harperj harperj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ervteng @harperj