-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[refactor] Move output files to a common results/ folder #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix incorrect configuration.yaml location Improve tests
@anupambhatnagar - Added you to the review for visibility as it will require a corresponding change to the CI pipeline. |
@ervteng you're right that this will break the daily CI runs. I think there are 3 places in the CI we'll need to update:
One of us could take a stab if that would be useful. Unrelatedly, I think the structure you listed in the PR description is a little off -- all files should be nested under the |
@harperj I've actually already made the CI changes in this PR: https://github.com/Unity-Technologies/ml-agents-cloud/pull/105 but definitely it needs a looksee from one of you to make sure I didn't miss anything. Seems to work when I tested it. I think getting rid of the |
Since the default Player.log path would be overwritten on subsequent runs, we should keep the Unity Player logs in the results folder for a training run. This change uses the -logFile CLI option to the Unity Player to set the path.
Proposed change(s)
This PR changes the artifact output directory to this structure:
In addition, we now output the RunOptions object as a YAML file
configuration.yaml
. When combined with PR #3815, the resulting YAML can then be used withmlagents-learn
to re-run the same run again.Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://docs.google.com/document/d/1uyk5JVNevfWy2DmqVHy19lcDzyQCNppPxkPOgJcQ7z4/edit#heading=h.5cr9b5kpfi98
Types of change(s)
Checklist
Other comments