-
Notifications
You must be signed in to change notification settings - Fork 17
Move Split PDF page functionality to hooks #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b78ff6f
requests-toolbelt dependency
mpolomdeepsense 5dd920e
Move hooks to separate subdirectory and refactor hooks registration
mpolomdeepsense 74ffbd7
Split pdf hook
mpolomdeepsense 0207dfd
Remove previous implementation of split pdf page functionality
mpolomdeepsense b4829f0
Add missing new line at the end of a file
mpolomdeepsense daf7f5e
Fix _clear_operation function indentation
mpolomdeepsense 6ca1451
Speakeasy generate client output
mpolomdeepsense a73fbe3
Remove TypeAlias import; fixes python 3.9 build
mpolomdeepsense d15518b
Support default type annotations in older python versions
mpolomdeepsense 8c7ced7
Fix logging initialization
mpolomdeepsense c038dfd
Fix parallel api calls
mpolomdeepsense e3ce00c
Added logging in case of an error
mpolomdeepsense a182d19
Replace relative imports
mpolomdeepsense 846941f
Reason to removing file extension from file name
mpolomdeepsense 9d5d532
Code cleanup
mpolomdeepsense 2e438e8
Explained why last page is skipped when sending parallel requests
mpolomdeepsense 25f1a96
split pdf hook tests
mpolomdeepsense 9042e99
Improve pdf file validation before splitting
mpolomdeepsense 2b850fb
Rollback to port 8000
mpolomdeepsense b017cf4
Use Speakeasy Files instead of a custom File class
mpolomdeepsense 7263f0e
Unit tests for _is_pdf method of split_pdf_hook
mpolomdeepsense a2ba3ae
Changed after error hooks order. We don't want to log error in case l…
mpolomdeepsense 9f920dc
Fix for when split_pdf_page is True and one paged pdf is sent. Docume…
mpolomdeepsense 24eae11
Test comment for more code understanding
mpolomdeepsense 6ddac3e
Handling an edge case for when a filename would be an empty string
mpolomdeepsense 4610465
Made empty filename edge case more robust
mpolomdeepsense 1db74d3
Handle edge case for when user inputs empty filename
mpolomdeepsense 1f14e24
Split pdf hook unit tests description
mpolomdeepsense edbed11
Replace relative imports
mpolomdeepsense File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.