Skip to content

[FXML-5912] Cherry-pick fix for tiling #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

[FXML-5912] Cherry-pick fix for tiling #535

merged 1 commit into from
Apr 28, 2025

Conversation

cferry-AMD
Copy link
Collaborator

@cferry-AMD cferry-AMD commented Apr 28, 2025 •
edited
Loading

This would have come up in a later bump but it seems we hit the bug in the current LLVM release. Cherry-pick the commit ahead of time.

@amirBish @cferry-AMD
[mlir][scf]-Fix reverse iterator overflow in loop traversal (llvm#128421
595b6c6 
)

Fix a bug in method `getUntiledProducerFromSliceSource` where address
sanitizer fails compilation on heap
buffer overflow for accessing value out of the iteration range.

This PR fixes the issue and adds a lit test to reproduce it.
@cferry-AMD cferry-AMD requested a review from TinaAMD April 28, 2025 08:54
@TinaAMD TinaAMD merged commit 7223b1f into feature/fused-ops Apr 28, 2025
5 checks passed
@TinaAMD TinaAMD deleted the corentin.cherry_pick_ac8b5a9e branch April 28, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaAMD TinaAMD TinaAMD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cferry-AMD @TinaAMD @amirBish