Skip to content

Add IterTools library #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Add IterTools library #154

merged 1 commit into from
Apr 11, 2019

Conversation

dastels
Copy link
Collaborator

@dastels dastels commented Apr 9, 2019

No description provided.

@dastels dastels requested a review from a team April 9, 2019 20:35
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dastels The link in drivers.rst to the IterTools RTD does not find an active project page: https://circuitpython.readthedocs.io/projects/itertools/en/latest/

Did you set up RTD for this library?

@@ -52,6 +52,7 @@ These libraries build on top of the low level APIs to simplify common tasks.
Framebuf Module <https://circuitpython.readthedocs.io/projects/framebuf/en/latest/>
Image Load <https://circuitpython.readthedocs.io/projects/imageload/en/latest/>
InfraRed Remote <https://circuitpython.readthedocs.io/projects/irremote/en/latest/>
IterTools <https://circuitpython.readthedocs.io/projects/itertools/en/latest/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dastels The link in drivers.rst to the IterTools RTD does not find an active project page: https://circuitpython.readthedocs.io/projects/itertools/en/latest/

Did you set up RTD for this library?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... that's not done by the build process? I assumed it was generated from all the doc directory stuff. I just copy pasted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not done by the build process, it requires manual setup on RTD. @brentru Please assist @dastels with getting it to the furthest point you are able. Then file an issue on the IterTools repo and tag me so I can finish it up. Thanks!

For now, this PR can be merged.

@brentru brentru merged commit 8c3855c into adafruit:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants