Skip to content

Add IterTools library #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Add IterTools library #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,3 +430,6 @@
[submodule "libraries/drivers/dymoscale"]
path = libraries/drivers/dymoscale
url = https://github.com/adafruit/Adafruit_CircuitPython_DymoScale.git
[submodule "libraries/helpers/itertools"]
path = libraries/helpers/itertools
url = https://github.com/adafruit/Adafruit_CircuitPython_IterTools.git
1 change: 1 addition & 0 deletions docs/drivers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ These libraries build on top of the low level APIs to simplify common tasks.
Framebuf Module <https://circuitpython.readthedocs.io/projects/framebuf/en/latest/>
Image Load <https://circuitpython.readthedocs.io/projects/imageload/en/latest/>
InfraRed Remote <https://circuitpython.readthedocs.io/projects/irremote/en/latest/>
IterTools <https://circuitpython.readthedocs.io/projects/itertools/en/latest/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dastels The link in drivers.rst to the IterTools RTD does not find an active project page: https://circuitpython.readthedocs.io/projects/itertools/en/latest/

Did you set up RTD for this library?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... that's not done by the build process? I assumed it was generated from all the doc directory stuff. I just copy pasted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not done by the build process, it requires manual setup on RTD. @brentru Please assist @dastels with getting it to the furthest point you are able. Then file an issue on the IterTools repo and tag me so I can finish it up. Thanks!

For now, this PR can be merged.

LED Animation <https://adafruit-circuitpython-led-animation.readthedocs.io/en/latest/>
Logging <https://circuitpython.readthedocs.io/projects/logging/en/latest/>
Mini ESP Tool <https://circuitpython.readthedocs.io/projects/miniesptool/en/latest/>
Expand Down
1 change: 1 addition & 0 deletions libraries/helpers/itertools
Open in desktop
Submodule itertools added at 7a8d75