Remove gamepad, utilise keypad. #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jul 16, 2021
This resolves a doc building problem where the `key_count` property of the Keys object needed to be used.
|
This is a different way than we've handled Sphinx before, but it works, and may be needed in the future. I'm ok with merging this and if we need to change it later, doing so. Thanks @jepler! |
|
@kattni Fyi. As this is dependent on keypad, which is disabled (see issue #4904 for the circuit python builds), the latest build will error out with keypad missing. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 20, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 4.4.0 from 4.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#106 from kattni/keypad-gamepad > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.1.0 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#56 from kattni/pixelbuf-update > Moved default branch to main > Moved CI to Python 3.7 Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.2.0 from 6.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#115 from kattni/pixelbuf-update > Moved default branch to main > Moved CI to Python 3.7 Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.2.0 from 2.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#63 from jerryneedell/jerryn_crc > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#63 from makermelissa/main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested CircuitPython build sizes with this frozen in and it built with enough space left.